921681 - Don't build ICU in developer builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

It's not enabled, and takes a *lot* of time to configure and build, especially on windows. There's no reason to inflict this on all developers, when the chances of them breaking ICU are *very* slim.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't build ICU in developer builds

Comment 2

[Jeff Walden [:Waldo]]

I'm fairly sure with the patchwork in bug 919872 we'll be able to enable this for desktop builds in a few days, or after summit, actually.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 811448 [details] [diff] [review]
Don't build ICU in developer builds

Review of attachment 811448 [details] [diff] [review]:
-----------------------------------------------------------------

I reluctantly agree that we're currently in a terrible situation where we're adding lots of pain to developer builds for no benefit. Once we start using ICU in some capacity we should revert this patch.

Also, we should look into either fixing ICU's build system for them or building it with our own moz.build files instead.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa12e5fe3a86

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa12e5fe3a86