Closed Bug 921681 Opened 6 years ago Closed 6 years ago

Don't build ICU in developer builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

It's not enabled, and takes a *lot* of time to configure and build, especially on windows. There's no reason to inflict this on all developers, when the chances of them breaking ICU are *very* slim.
I'm fairly sure with the patchwork in bug 919872 we'll be able to enable this for desktop builds in a few days, or after summit, actually.
Comment on attachment 811448 [details] [diff] [review]
Don't build ICU in developer builds

Review of attachment 811448 [details] [diff] [review]:
-----------------------------------------------------------------

I reluctantly agree that we're currently in a terrible situation where we're adding lots of pain to developer builds for no benefit. Once we start using ICU in some capacity we should revert this patch.

Also, we should look into either fixing ICU's build system for them or building it with our own moz.build files instead.
Attachment #811448 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/aa12e5fe3a86
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.