Closed Bug 921718 Opened 7 years ago Closed 6 years ago

Move MediaList to WebIDL

Categories

(Core :: DOM: CSS Object Model, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Attachment #813269 - Flags: review?(bzbarsky)
Comment on attachment 813266 [details] [diff] [review]
Part a: Rename nsMediaList::Count to Length and make it return uint32_t;

r=me
Attachment #813266 - Flags: review?(bzbarsky) → review+
Comment on attachment 813269 [details] [diff] [review]
Part b: Move MediaList to WebIDL;

>+++ b/dom/webidl/MediaList.webidl
>@@ -0,0 +1,15 @@
>+interface MediaList {

[ArrayClass]

http://dev.w3.org/csswg/cssom/#the-medialist-interface
Comment on attachment 813269 [details] [diff] [review]
Part b: Move MediaList to WebIDL;

>+++ b/dom/webidl/MediaList.webidl

Please link to relevant spec.

And yes, [ArrayClass].

>+           attribute DOMString        mediaText;

Spec says [TreatNullAs=EmptyString].

While you're here, do you want to add the stringifier bit the spec has too?  Followup is fine.

>+++ b/layout/style/nsCSSStyleSheet.cpp
>+  NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY

You need to make nsMediaList cycle-collected, no?

>+++ b/layout/style/nsIMediaList.h
>+    // Not sure if this is good enough.

It's probably OK, actually.

Please document explicitly which WebIDL methods you're just having call the XPCOM versions.

r- because of the cc thing; really need that fixed.
Attachment #813269 - Flags: review?(bzbarsky) → review-
Attachment #813269 - Attachment is obsolete: true
Attachment #814219 - Flags: review?(bzbarsky)
Comment on attachment 814219 [details] [diff] [review]
Part b: Move MediaList to WebIDL (v2)

To repeat:

Please document explicitly which WebIDL methods you're just having call the XPCOM versions.

r=me with that done.
Attachment #814219 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/df945816055e
https://hg.mozilla.org/mozilla-central/rev/a7d1571cea89
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.