921718 - Move MediaList to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Rename nsMediaList::Count to Length and make it return uint32_t;

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Move MediaList to WebIDL;

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 813266 [details] [diff] [review]
Part a: Rename nsMediaList::Count to Length and make it return uint32_t;

r=me

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 813269 [details] [diff] [review]
Part b: Move MediaList to WebIDL;

>+++ b/dom/webidl/MediaList.webidl
>@@ -0,0 +1,15 @@
>+interface MediaList {

[ArrayClass]

http://dev.w3.org/csswg/cssom/#the-medialist-interface

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 813269 [details] [diff] [review]
Part b: Move MediaList to WebIDL;

>+++ b/dom/webidl/MediaList.webidl

Please link to relevant spec.

And yes, [ArrayClass].

>+           attribute DOMString        mediaText;

Spec says [TreatNullAs=EmptyString].

While you're here, do you want to add the stringifier bit the spec has too?  Followup is fine.

>+++ b/layout/style/nsCSSStyleSheet.cpp
>+  NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY

You need to make nsMediaList cycle-collected, no?

>+++ b/layout/style/nsIMediaList.h
>+    // Not sure if this is good enough.

It's probably OK, actually.

Please document explicitly which WebIDL methods you're just having call the XPCOM versions.

r- because of the cc thing; really need that fixed.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Move MediaList to WebIDL (v2)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 814219 [details] [diff] [review]
Part b: Move MediaList to WebIDL (v2)

To repeat:

Please document explicitly which WebIDL methods you're just having call the XPCOM versions.

r=me with that done.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/df945816055e
https://hg.mozilla.org/mozilla-central/rev/a7d1571cea89