Closed Bug 921744 Opened 6 years ago Closed 6 years ago

Multiple master password prompts with multiple Google CalDAV OAuth2 calendars

Categories

(Calendar :: Provider: CalDAV, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 901329

People

(Reporter: mmecca, Assigned: mmecca)

Details

Attachments

(1 file)

We currently use the password manager to store the refresh token for each OAuth2 calendar, but nsILoginManager.findLogins triggers the master password dialog if one is set and it hasn't been entered already. Since we asynchronously load the refresh token for all calendars at startup, we get a master password dialog for each calendar.
Attached patch Fix v1Splinter Review
This adds an asynchronous wrapper for passwordManagerGet, which queues the login requests to prevent subsequent lookups until the first one (and potential master password prompt) is complete.

In order to make this asynchronous I had to change the way the oauth refreshToken property getter works, do you think this could cause issues elsewhere?
Attachment #811535 - Flags: review?(philipp)
Attachment #811535 - Flags: review?(philipp)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 901329
You need to log in before you can comment on or make changes to this bug.