Closed
Bug 921751
Opened 11 years ago
Closed 11 years ago
Preprocessor.py's -o option writes incorrect line endings on Windows
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
711 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Bug 874711 switched from using output redirection to the -o option to create files. Preprocessor.py was explicitly setting its stdout to binary so that it could generate the requested line endings on Windows. However the -o option does not, so it is generating bogus \r\r\n line endings for preference files.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #811553 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb456791435
|
||
Comment 3•11 years ago
|
||
Backed out for check-sync-dirs bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/94dd2ef0b98e https://tbpl.mozilla.org/php/getParsedLog.php?id=28624570&tree=Mozilla-Inbound
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5ab2c3fa54
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf5ab2c3fa54
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•