Closed Bug 921751 Opened 6 years ago Closed 6 years ago

Preprocessor.py's -o option writes incorrect line endings on Windows

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 874711 switched from using output redirection to the -o option to create files. Preprocessor.py was explicitly setting its stdout to binary so that it could generate the requested line endings on Windows. However the -o option does not, so it is generating bogus \r\r\n line endings for preference files.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #811553 - Flags: review?(ted)
Blocks: 921746
Attachment #811553 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/bf5ab2c3fa54
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.