921828 - (app-menu) [Window Management] Refactor ListMenu and move it to AppWindow + implement System Wide Menu if needed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

I observed some issues due to we're sharing the same list menu UI in so many different use cases.
Proposal:
AppWindow shall have it's own list menu + context menu UI,
and if system needs a system wide list menu not belong to any app frame, we shall create another one under #screen element.

I don't recall there's a need to have system wide menu now though.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

wrong bug..

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

WIP,
https://github.com/cctuan/gaia/commit/b05c830a5be43c74666576b8c8464b578cfaa96b
The pb I have now is the detail.id from mozChromeEvent is always the same, so, if I either cancel or choose one activity, all of the action menus of the other app will also be invalid.

I traced ActivitiesGlue.js of gecko, and found out that , ActivitiesDialog always pass the same id as 0 whenever we create a new one..
I'll keep looking into it.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: bug-921828.patch

This patch will generate different id for each activitiesDialog.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Generate action menu for each AppWindow on gaia.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8351361 [details]
PR to master

Hi Alive,
please kindly help to review it. Thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8351361 [details]
PR to master

Well done but see github.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8351361 [details]
PR to master

Hi Alive, patch is updated. Please kindly check it again. Thanks.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8351361 [details]
PR to master

r+ thank you much

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
https://github.com/mozilla-b2g/gaia/commit/35a63b2cfc631f89c146a72ff9a3f0b916d9d43a

Comment 10

[Kevin Grandon :kgrandon]

This has been reverted due to breaking the linter rule: https://github.com/mozilla-b2g/gaia/commit/1d2eaab3a0eb6e9535aca8e220e42c9924f27bb4

Please fix the errors and re-land after a green travis pull request. Thanks.

Comment 11

[Kevin Grandon :kgrandon]

I suppose this just caused the tree to go red because of the new JSHint linter. One quick fix would be to add the files to the xfail.list file, but ideally we could fix the syntax and reland.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Linter error is updated and add test in .jshintignore

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Travis is all green now.
https://github.com/mozilla-b2g/gaia/commit/0cdbd10dd200799710c93843dc5c20e42b7594f6