922006 - [Dialer] Refactor dialer.js for easier unit testing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We have an initial version of unit test on dialer.js.
But since onload listener is included in dialer.js, we have to
expose the onload listener and remove the listener in unit test actively
to prevent unwanted initialization on KeypadManager that breaks unit test.

One possible solution is, as mentioned in Bug 903278 comment 22, to refactor
onload listener in each window to an independent js file to prevent unwanted
initialization.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Reset blocking flag (came from cloning)

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Onload listeners are refactored, See pull request for detail.

I tested with normal dialing/receiving/activity.
in my test by now launch time is not changing after applying this patch.
Specifically,
dialing out from contact spends about 3.7s (when dialer hasn't launched)
and 2.4s (when dialer has launched) both before and after applying the patch.
Please tell me if there are other performance metrics that need to pay attention.

Etienne may you review this patch?
This is not a blocker so we don't have to do it very eager though.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8346490 [details]
patch

r=me with a tiny nit.

This is a welcomed change, perfect for the beginning of a cycle :)
Also did some manual testing and found 0 issues, including playing with the dial activity and locked/unlocked incoming calls.

Cheers!

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for the reviewing and testing Etienne!

We can then start to add unit test for dialer.js in later commits.
merged after fixing the nit:
master
https://github.com/mozilla-b2g/gaia/commit/f1d060293091370d5315d01f4af91139dfcba0cb