922019 - Fix broken progress locator for video app object

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

There is a locator (and wait) in the video app object for the progress indicator, however the locator is incorrect.

Currently we're looking for an element with ID 'progress':
https://github.com/mozilla-b2g/gaia/blob/aaef2ff42f99fbeba30a1f5b8aa3bed4e011f8e2/tests/python/gaia-ui-tests/gaiatest/apps/videoplayer/app.py#L13

We should be looking for the element with ID 'throbber':
https://github.com/mozilla-b2g/gaia/blob/aaef2ff42f99fbeba30a1f5b8aa3bed4e011f8e2/apps/video/index.html#L136

We should also add a test that checks this element is visible when loading content, otherwise we won't detect any future changes to this element that causes the locator to break.

Comment 1

[Viorela Ioia [:viorela]]

Please assign this to me. Bebe will help me with the necessary steps.

Comment 2

[Viorela Ioia [:viorela]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12574

Comment 3

[Viorela Ioia [:viorela]]

:davehunt I updated the locator and I added "wait_for_element" to check that the  element is visible when loading content.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 812603 [details] [diff] [review]
https://github.com/mozilla-b2g/gaia/pull/12574

Thanks for the patch Viorela. The locator looks fine, but I commented in the pull request about the visibility check. If we can improve this, we can get it landed.

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 812603 [details] [diff] [review]
https://github.com/mozilla-b2g/gaia/pull/12574

I updated the pull request. Can you review it again? Thanks

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 812603 [details] [diff] [review]
https://github.com/mozilla-b2g/gaia/pull/12574

Comments in the pull request.

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 812603 [details] [diff] [review]
https://github.com/mozilla-b2g/gaia/pull/12574

I was never flagged for review again, but I did just review this again, and it's still an r-. Comments in the PR.

Comment 8

[Viorela Ioia [:viorela]]

Attachment: update PR

Comment 9

[Bob Silverberg [:bsilverberg]]

Comment on attachment 828032 [details] [review]
update PR

LGTM. Thanks Viorela.

Comment 10

[Bob Silverberg [:bsilverberg]]

Landed in https://github.com/mozilla-b2g/gaia/commit/a56738c966eba47bb985bea1c6e117e7beaa4093