Closed Bug 922020 Opened 11 years ago Closed 11 years ago

[Homescreen] Lazy load DOM nodes via HTML Import polyfill

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Keywords: perf, Whiteboard: [c=progress p= s=2013.10.04 u=])

Attachments

(1 file, 1 obsolete file)

Patch v1
190 bytes, text/html
kgrandon
: review+
Details 
In order to be faster on the start-up
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
blocking-b2g: --- → koi?
Attached file Patch v1 (obsolete) — 

        Attachment #811952 -
        Flags: review?(21)

    
    

    
  
Comment on attachment 811952 [details]
Patch v1

<html>
  <head>
    <meta http-equiv="Refresh"
    content="2; url=https://github.com/mozilla-b2g/gaia/pull/12547" />
  </head>
  <body>
    Redirect to pull request #12547
  </body>
</html>

    
    

    
  

      
      
      
      

        Attached file
          
        Patch v1
        — 
      

    


  

        Attachment #811952 -
        Attachment is obsolete: true

        Attachment #811952 -
        Flags: review?(21)

        Attachment #811953 -
        Flags: review?(21)

    
  
Summary: Lazy load Contacts DOM nodes via HTML Import polyfill → Lazy load DOM nodes via HTML Import polyfill
Keywords: perf

    
  
Blocks: 914875

    
  
Whiteboard: [c=progress p= s= u=]

    
    

    
  
Comment on attachment 811953 [details]
Patch v1

Kevin is the HTML nodes importer guy. Let's see what he thinks of that.

        Attachment #811953 -
        Flags: review?(21) → review?(kgrandon)

    
    

    
  
I totally agree, thanks Vivien

    
    

    
  
Comment on attachment 811953 [details]
Patch v1

Hi Cristian,

Very nice work. Looks like E.me is pretty turbulent, so I think you need to rebase this against master.

I added one comment to github, please resolve and mark me as reviewer again. Thanks!

        Attachment #811953 -
        Flags: review?(kgrandon)

    
    

    
  
We don't block on performance bugs. Please ask for approval once it's landed on master and we have an idea about the performance impact.
blocking-b2g: koi? → -
Summary: Lazy load DOM nodes via HTML Import polyfill → [Homescreen] Lazy load DOM nodes via HTML Import polyfill

    
  

        Attachment #811953 -
        Flags: review?(kgrandon)

    
    

    
  
Implemented your suggestion, thanks a lot

    
    

    
  
Hi Kevin, can you see it or you prefer give the review up to another person?
Flags: needinfo?(kgrandon)

    
    

    
  
Hi, been on an airplane all day but I'll look at it soon :)
Flags: needinfo?(kgrandon)

    
    

    
  
ok, no worries, I don't know that :)

    
    

    
  
Comment on attachment 811953 [details]
Patch v1

Hi, this looks good for me - thanks for the implementation work! I would really like to see the duplicate test HTML go away for this patch, but I also don't mind doing it in a follow-up patch. Feel free to rebase and land. Thanks!

        Attachment #811953 -
        Flags: review?(kgrandon) → review+

    
    

    
  
Done, now I am waiting for Travis results, thanks for the review, very useful

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/d14a732052e93d018ab6460a8776a800e2abff25
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [c=progress p= s= u=] → [c=progress p= s=2013.10.04 u=]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: