922166 - authenticatedSearch that returns non published projects and deleted projects for the user that owns them

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Scott [:thecount] Downe]

We need a path for users to get their own unpublished saved make data.

We I had a authenticatedSearch path started in bug 919710 but pulled it out and moved it into this ticket.

authenticatedSearch can only be used by an authenticated app server side. Regular search is used client side.

Comment 1

[Scott [:thecount] Downe]

This was blocking a mozfest ticket, so i also gave this the mozfest tag, however, the ticket it was blocking is no longer mozfest, so neither should this.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/190

you'll need the corresponding makeapi-client patch to try this out.

I tested using the node REPL by requiring in the client library to make authenticated/anonymous requests.

Comment 3

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/makeapi-client/pull/24

Comment 4

[Scott [:thecount] Downe]

I broke my local build trying to get this working.

I wonder, should jbuck just review this? Was I missing steps that are just obvious to some?

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 8366221 [details] [review]
https://github.com/mozilla/MakeAPI/pull/190

Turns out the break was something that came with updating to master because of recent additions.

Good now.

I was able to do bug 913731 with this patch a ok.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/makeapi-client

https://github.com/mozilla/makeapi-client/commit/408b4d2c8836d347ce37dedfa48f290b21aa9612
Bug 922166 - protected search used when Hawk credentials supplied

Comment 7

[Chris DeCairos (:cade)]

Comment on attachment 8366221 [details] [review]
https://github.com/mozilla/MakeAPI/pull/190

Changed some things - another review please!

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/58de7d5707a08927d84a15a101c9648ab4c1d8dd
Bug 922166 - add protected search route that surfaces 'unpublished' makes. A valid Hawk Authentication header must be supplied to use the route.