922226 - redirect when attachments contain reviewboard URLs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mark Côté [:mcote]]

As with bug 916906, it would be great if we could do something similar for ReviewBoard, redirecting when patches contain only a http[s]://reviewboard.mozilla.org/.../ link.

Comment 1

[:glob 🎈]

Attachment: 922226_1.patch

- no longer require the "is patch" checkbox to be unchecked (checking it is an easy mistake to make)
- add review board requests in the form
    https://reviewboard.allizom.org/r/###
    https://reviewboard-dev.allizom.org/r/###
  where ### is the review number

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8338264 [details] [diff] [review]
922226_1.patch

Review of attachment 8338264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good works as expected. r=dkl

::: extensions/BMO/Extension.pm
@@ +621,5 @@
> +    if ($url =~ m#^https://github\.com/[^/]+/[^/]+/pull/\d+/?$#i) {
> +        $attributes->{mimetype} = GITHUB_PR_CONTENT_TYPE;
> +        $attributes->{ispatch}  = 0;
> +    }
> +    elsif ($url =~ m#^https://reviewboard(?:-dev)\.allizom\.org/r/\d+/?#i) {

Add ? to regexp on commit:

 elsif ($url =~ m#^https://reviewboard(?:-dev)?\.allizom\.org/r/\d+/?#i) {

Comment 3

[:glob 🎈]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
modified template/en/default/attachment/edit.html.tmpl
Committed revision 9165.