922239 - disable the slow script dialog for the Webapp Runtime

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P2)

Description

[Marco Castelluccio [:marco] (back May 20)]

The slow script dialog is disabled on B2G, we have a different situation on desktop but we should consider disabling it too (the user can kill the application with OS-specific mechanisms, like he does with his native apps).

Comment 1

[Boris Zbarsky [:bzbarsky]]

"The application" being Firefox?

The point of the slow script dialog is to enable the user to kill the one tab involved without killing all the other tabs the user has.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Or put another way, from the user's point of view, what is the benefit of this bug?

Note that for b2g disabling makes sense because a hanging app does not hang the phone UI, and a hanging browser tab doesn't hang the browser UI.

Comment 3

[Marco Castelluccio [:marco] (back May 20)]

Sorry, I should've pointed out that I'm talking about the Webapp Runtime.

Comment 4

[Bill Walker [:bwalker] [@wfwalker]]

see also bug 921519

Comment 5

[Donovan Preston [:fzzzy]]

Attachment: webapprt-disable-slowscript.patch

Disable the slow script dialog in the web app runtime.

Comment 6

[Donovan Preston [:fzzzy]]

Attachment: slowscript.zip

Simple app used to test this patch.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to Boris Zbarsky [:bz] from comment #1)
> "The application" being Firefox?
> 
> The point of the slow script dialog is to enable the user to kill the one
> tab involved without killing all the other tabs the user has.

(In reply to Boris Zbarsky [:bz] from comment #2)
> Or put another way, from the user's point of view, what is the benefit of
> this bug?
> 
> Note that for b2g disabling makes sense because a hanging app does not hang
> the phone UI, and a hanging browser tab doesn't hang the browser UI.

(In reply to Marco Castelluccio [:marco] from comment #3)
> Sorry, I should've pointed out that I'm talking about the Webapp Runtime.

To add a bit more detail: disabling the dialog in the runtime makes apps appear more native, since native apps don't display such a dialog.  It doesn't prevent users from killing such apps, which they can still do via the native mechanism (the Task Manager on Windows, Force Quit on Mac).  Nor does it hang any other UI, since each app runs in its own process.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 824776 [details] [diff] [review]
webapprt-disable-slowscript.patch

Looks great, works well. r=myk!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/69a8799655a4

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69a8799655a4