Closed Bug 922239 Opened 9 years ago Closed 9 years ago

disable the slow script dialog for the Webapp Runtime

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: marco, Assigned: fzzzy)

Details

Attachments

(2 files)

The slow script dialog is disabled on B2G, we have a different situation on desktop but we should consider disabling it too (the user can kill the application with OS-specific mechanisms, like he does with his native apps).
"The application" being Firefox?

The point of the slow script dialog is to enable the user to kill the one tab involved without killing all the other tabs the user has.
Or put another way, from the user's point of view, what is the benefit of this bug?

Note that for b2g disabling makes sense because a hanging app does not hang the phone UI, and a hanging browser tab doesn't hang the browser UI.
Sorry, I should've pointed out that I'm talking about the Webapp Runtime.
Component: XPConnect → Webapp Runtime
Product: Core → Firefox
Summary: Consider disabling the slow script dialog → Consider disabling the slow script dialog for the Webapp Runtime
Priority: -- → P2
Summary: Consider disabling the slow script dialog for the Webapp Runtime → disable the slow script dialog for the Webapp Runtime
Assignee: nobody → dpreston
Disable the slow script dialog in the web app runtime.
Attachment #824776 - Flags: review?(myk)
Attached file slowscript.zip
Simple app used to test this patch.
(In reply to Boris Zbarsky [:bz] from comment #1)
> "The application" being Firefox?
> 
> The point of the slow script dialog is to enable the user to kill the one
> tab involved without killing all the other tabs the user has.

(In reply to Boris Zbarsky [:bz] from comment #2)
> Or put another way, from the user's point of view, what is the benefit of
> this bug?
> 
> Note that for b2g disabling makes sense because a hanging app does not hang
> the phone UI, and a hanging browser tab doesn't hang the browser UI.

(In reply to Marco Castelluccio [:marco] from comment #3)
> Sorry, I should've pointed out that I'm talking about the Webapp Runtime.

To add a bit more detail: disabling the dialog in the runtime makes apps appear more native, since native apps don't display such a dialog.  It doesn't prevent users from killing such apps, which they can still do via the native mechanism (the Task Manager on Windows, Force Quit on Mac).  Nor does it hang any other UI, since each app runs in its own process.
Comment on attachment 824776 [details] [diff] [review]
webapprt-disable-slowscript.patch

Looks great, works well. r=myk!
Attachment #824776 - Flags: review?(myk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69a8799655a4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.