922248 - [Contacts] Cannot update a previously exported contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Salvador de la Puente González [:salva]]

STR
1- Open Contacts app
2- Create a new contact with only name
3- Export this contact to the SIM
4- Delete this contact
5- Import the contacts from the SIM
6- Look the previously exported contact and edit it
7- Delete the name completely and add a family name
8- Click update

EXPECTED:
The contact is properly updated

ACTUAL:
The process stucks in the matching process with this error:
[JavaScript Error: "TypeError: aContact.givenName[0] is undefined" {file: "app://communications.gaiamobile.org/contacts/js/contacts_matcher.js" line: 431}]

Comment 1

[Jose Manuel Cantera]

Attachment: 12562.html

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 812477 [details]
12562.html

Working fine. Please, review my comment on GitHub, it is a not blocking comment but if you agree, fix it as a code improvement.

Wait for Travis to be green before merging.
Thank you very much.

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/7cf3eb493e6819eafaeb61a9081eb17a7b199e71

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7cf3eb493e6819eafaeb61a9081eb17a7b199e71 to:
v1.2: 2f602f0849c1bb3dd160469be16c90681fd986f2

Comment 5

[isabelrios]

Verified on 10/09 v1.2 build:
Gecko-bd1bd24
Gaia-1499c58

Comment 6

[Shilpa Suresh]

As per comment 5, Changing the Status-b2g-v1.2 Tracking flags to Verified.