922252 - [dev] Implement flow change for China

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Wil Clouser [:clouserw]]

Attachment: china.proposal.pdf

We have approval from Jack that the attached flow will work.  Ops is working on getting their hardware in place, so we're good to start on the developer side.

This bug covers the attached flow:

1) On initial upload, "China" has a question-mark floating next to it with some short explanation of the developer being able to request to be in China but it must go through an additional review.

2) If the developer views their app regions after they submit, there should be some indicator of status (this is what is in the attached mockup).  Either checked with no notes (which means approved), checked with Waiting Approval, or Rejected (and checkbox unchecked) works.

3) If the developer rechecks the checkbox it should clear the Rejected flag and go back to Waiting Approval.

4) There should be an authenticated API endpoint which will list apps requesting listing in the Chinese Marketplace. (Read-only)  No UI - this is API only.

5) There should be a read/write or write-only API which will modify a flag for each app requesting listing, corresponding to Approved, Waiting Approval (null?), or Rejected.  No UI - this is API only.

Please feel free to file child bugs as appropriate.

Comment 1

[Wil Clouser [:clouserw]]

6) It's not called out specifically in comment 0, but apps which are "waiting approval" or "rejected" for China shouldn't show up in the Chinese Marketplace.  It is a valid scenario for an app to only want to be listed in China and for it to be waiting approval or rejected there, in which case it shouldn't appear anywhere in any marketplace.

Comment 2

[Matt Basta [:basta]]

Would it make sense to tie this to content restrictions? I.e.: make China a region that can be excluded under the new "strict" exclusions, but readonly to the developer. The China region would be excluded by default and only be modifiable by reviewers/admins.

Just an idea. It might be easier and be more manageable in the long term than building out a whole bunch of one-offs, especially if we end up with even more regions that require extra review processes. I've been wrong before, though.

Comment 3

[Wil Clouser [:clouserw]]

One of the things I liked about the flow I outlined above is that the developer opts in, and then the censor approves it (or not).

If we overload a region opt-in flag, you lose the ability for the developer to opt-out.  Eg.  If the China region is excluded by default and only modifiable by censors/admins, then a developer doesn't get the ability to say "I don't want to distribute in China."

Comment 4

[Matt Basta [:basta]]

Good point.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Added to Fireplace the region and MCC detection (MNC pending the carriers which which we ship):
https://github.com/mozilla/fireplace/commit/5c031ce

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Added to Zamboni the region:
https://github.com/mozilla/zamboni/commit/b630029

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Added MNC codes to carrier detection:
https://github.com/mozilla/fireplace/commit/4bb220d

Comment 8

[Francis Lee [:frlee]]

hi Caitlin,

is it possible to provide some progress here? 11/5 is already passed. i wonder if we have fixed this issue.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

There is progress here - expect to see code landed in production by next Tuesday, 11/12.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/a533fdb
https://github.com/mozilla/zamboni/commit/c32d6dd

Steps to verify
---------------
When the waffle flag (`special-regions`) is disabled, please ensure that for both free and paid apps:
1) The "China" option does not show up in the devhub yet. (It's fine that it shows up in Fireplace's region drop-down menu.)

When the waffle flag (`special-regions`) is enabled, please ensure that for both free and paid apps:
1) By default the "China" option is unchecked and has the text "(requires additional review)" next to it.
2) When checked, the "China" option should have the text "(awaiting approval)" next to it.

When the command-line tool (`exclude_region`) has been run, please ensure that for both free and paid apps:
1) No apps show up in China yet.


What's left?
------------
In bug 937985 we will direct the user to the Compatibility/Payments page after submission.
In bug 937985 we will direct the user to the Compatibility/Payments page after submission.


Screenshots
-----------
http://f.cl.ly/items/0E0S1a3d3D0N2L3C212l/Screen%20Shot%202013-11-12%20at%208.29.58%20PM.png
http://f.cl.ly/items/0k030t3C1x0J1W0Q2t3y/Screen%20Shot%202013-11-12%20at%208.30.12%20PM.png
http://f.cl.ly/items/2q1I0O1t0u230R2W4046/Screen%20Shot%202013-11-12%20at%208.30.47%20PM.png


Push notes
----------
When ready to expose the "China" option for developers:

     python manage.py migrate_geodata --settings=settings_local_mkt
     python manage.py exclude_region cn --settings=settings_local_mkt

To enable the waffle *flag* (which I've enabled already on -dev):

     echo "update waffle_flag_mkt set everyone=1 where name='special-regions'" | python manage.py dbshell --settings=settings_local_mkt

Comment 11

[Christopher Van Wiemeersch [:cvan]]

In bug 937988 we will expose the pending apps in China and allow the reviewers to approve/reject the apps for China.

Comment 12

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/1aa87e6

Comment 13

[David Bialer [:dbialer]]

Unlike other dissapproval processes, this simply deselects China and no feedback is given to the developer.  The unhappy path wasn't really specified.  

Should there be developer feedback ('we rejected it since the content was deemed innappropriate for china'?  

Any thoughts on this from the China team?