Closed Bug 922268 Opened 11 years ago Closed 11 years ago

Remove empty makefiles

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

      No description provided.
Attached patch Patch v1Splinter Review
Attachment #812217 - Flags: review?(gps)
Should we use |skip-if = true| for disabling those tests? (Since presumably we note skipped tests in the summary etc)
Comment on attachment 812217 [details] [diff] [review]
Patch v1

Review of attachment 812217 [details] [diff] [review]:
-----------------------------------------------------------------

This patch puts a smile on my face. Thank you!

To answer edmorly's question: yes, we should use skip-if = true. However, bug 921987 is making that not honoured for mochitest manifests, so we can't yet. I'm sure it will get fixed eventually.
Attachment #812217 - Flags: review?(gps) → review+
(In reply to Ed Morley [:edmorley UTC+1] from comment #2)
> Should we use |skip-if = true| for disabling those tests? (Since presumably
> we note skipped tests in the summary etc)

We do not currently note skipped tests while running Mochitest. That needs to be added.
We properly handle skip-if in inbound. Feel free to do this right.

We currently filter installation of skip-if for mochitests in the build system. Once the mochitest runner uses manifests, we'll have the build system install all tests, just like xpcshell does.
https://hg.mozilla.org/mozilla-central/rev/8736bb8af4e1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: