Closed Bug 922337 Opened 11 years ago Closed 11 years ago

Remove unused viewport zooming code from /browser/metro

Categories

(Firefox for Metro Graveyard :: Pan and Zoom, defect)

All
Windows 8.1
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
All of this code is dead, disabled, or unused.

There's more stuff we can remove in base/content/bindings/browser.xml, but I didn't have time to wade into it...
Attachment #812266 - Flags: review?(jmathies)
Attached patch patch v2Splinter Review
Missed a few spots.
Attachment #812266 - Attachment is obsolete: true
Attachment #812266 - Flags: review?(jmathies)
Attachment #812271 - Flags: review?(jmathies)
Comment on attachment 812271 [details] [diff] [review]
patch v2

Review of attachment 812271 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #812271 - Flags: review?(jmathies) → review+
Found a test failure locally; pushed to Try with a minor change to fix that:
https://tbpl.mozilla.org/?tree=Try&rev=39c5fa32bb6f
https://hg.mozilla.org/mozilla-central/rev/d63ba64a8319
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: