922378 - [Messages] Some tests for SMS are failing locally

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Github PR at https://github.com/mozilla-b2g/gaia/pull/12558

---
 apps/sms/test/unit/recipients_test.js |    6 ++++++
 apps/sms/test/unit/thread_ui_test.js  |   24 ++++++++++++++++--------
 2 files changed, 22 insertions(+), 8 deletions(-)


These tests were failing locally for me, but not on Travis. This is another problem that I'll look into shortly.

Comment 2

[Rick Waldron [:rwaldron]]

Comment on attachment 812329 [details] [diff] [review]
patch v1

Review of attachment 812329 [details] [diff] [review]:
-----------------------------------------------------------------

I was able to reproduce the failures locally as well. I'm mostly concerned about why these suddenly began failing. I can't pin point any new code that would've created the issue. 

These changes fix the fails and look good to me! r=me

Comment 3

[Rick Waldron [:rwaldron]]

Should we wait until Travis is green to land this? (Hopefully it will be green by the time you get to this tomorrow)

Comment 4

[Julien Wajsberg [:julienw]]

master: 5de99819ca192295a8179ddd345de6cf7ebb2287

Comment 5

[Julien Wajsberg [:julienw]]

(In reply to Rick Waldron from comment #3)
> Should we wait until Travis is green to land this? (Hopefully it will be
> green by the time you get to this tomorrow)

oops too late, I pushed before seeing your message here.

The changes looked completely unrelated (intermittent (?) problems in other apps) as you said on the PR, so I pushed it.

Comment 6

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> (In reply to Rick Waldron from comment #3)
> > Should we wait until Travis is green to land this? (Hopefully it will be
> > green by the time you get to this tomorrow)
> 
> oops too late, I pushed before seeing your message here.
> 
> The changes looked completely unrelated (intermittent (?) problems in other
> apps) as you said on the PR, so I pushed it.

No worries, looks like travis has gone green anyway :)

Comment 7

[Julien Wajsberg [:julienw]]

a=tests
v1.2: e019041eb7ea7a4615f8c8b09a9b96554590d312