Closed Bug 922432 Opened 13 years ago Closed 12 years ago

"invalid asm.js statement" shows wrong line number (semicolon of the previous statement)

Categories

(Core :: JavaScript Engine, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jruderman, Assigned: luke)

Details

(Keywords: testcase)

Attachments

(1 file)

function v() { "use asm"; var x = 5; y = 5; } Result: p.js:4:12 warning: asm.js type error: invalid asm.js statement Expected: p.js:5:2 warning: asm.js type error: invalid asm.js statement
Attached patch fix-error-msg — — Splinter Review
Bug 900669 adds a peekTokenPos() which is what we need here to report the position of the error.
Assignee: nobody → luke
Status: NEW → ASSIGNED
Attachment #812651 - Flags: review?(sstangl)
Attachment #812651 - Flags: review?(sstangl) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: