Closed Bug 922471 Opened 11 years ago Closed 11 years ago

Remove MOZ_PNG_READ and MOZ_PNG_WRITE global defines

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

Details

Attachments

(1 file, 1 obsolete file)

v02 Remove MOZ_PNG_READ and WRITE defines
3.91 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
MOZ_IMG_DECODERS was removed as a configurable item several years ago (August 2010, bug #513681).  I guess MOZ_IMAGE_ENCODERS was removed around the same time.  Since MOZ_PNG_READ and MOZ_PNG_WRITE depended on those, they don't need to be maintained in moz.build or Makefile.in any more but can just be defined in libpng/mozpngconf.h, thereby simplifying the compile lines, Makefile.in, and moz.build in media/libpng and image/decoders.
Blocks: 832390
Flags: needinfo?(ryanvm)

    
    

    
  


  
The v01 patch included some changes to moz.build that are not relevant and should be included in a new patch to bug #832390 instead.  They don't hurt anything here but are just clutter so I removed them from the v02 patch and will incorporate them in the next ARM support patch in bug #832390.

        Attachment #812742 -
        Attachment is obsolete: true

    
  

        Attachment #812817 -
        Attachment description: v01 Remove MOZ_PNG_READ and WRITE defines → v02 Remove MOZ_PNG_READ and WRITE defines

    
    

    
  
Change priority to match that of bug #832390 which depends on this.
Severity: minor → normal

    
    

    
  
Comment on attachment 812817 [details] [diff] [review]
v02 Remove MOZ_PNG_READ and WRITE defines

Try runs all green.  r?

        Attachment #812817 -
        Flags: review?(jmuizelaar)

        Attachment #812817 -
        Flags: review?(jmuizelaar) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d3944585f130
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: