92251 - Error msg incorrect when Send Later fails

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[David :Bienvenu]

When send later fails, we put up an error message saying that the send succeeded
but the copy to the sent folder failed. This is incorrect. Please see bug 83682
for more details on how to reproduce this.

Comment 1

[scottputterman]

adding nsenterprise keyword.  If not taken for that, we should still consider
this as part of general compose window error cleanup and improvements

Comment 2

[scottputterman]

adding nsenterprise+.  Do you think we can get this as part of the other error
handling work you are doing?

Comment 3

[Jean-Francois Ducarroz]

sure.

Comment 4

[Jean-Francois Ducarroz]

The fix is to rewrite the way we handle errors in message compose. That should
fix various problem we have today.

Comment 5

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

Comment 6

[Jean-Francois Ducarroz]

This is a rather big patch but in fact, half of it is to add code to help
simulate errors in order to validate the code.

Comment 7

[Jean-Francois Ducarroz]

R=varada

Comment 8

[David :Bienvenu]

-[ref] native nsStringRef(nsString);
+//[ref] native nsStringRef(nsString);  Already defined though includes!

just remove this is you don't need it. 

similarly for
+//not used. #define NS_ERROR_SERVER_ERROR                      
NS_MSG_GENERATE_FAILURE(12518)

and 
+//not used. #define NS_MSG_ATTACHMENT_TYPE_MISMATCH            
NS_MSG_GENERATE_FAILURE(12552)

the code looks cleaner w/o commented out stuff.

Also, you need to fix this in sMsgSendReport.h

:
+#endif
\ No newline at end of file

Also, it looks like you have Checksimulatederror turned on in the diffs - you're
not going to check it in that way, right?

this should be "this should never happen".
+        /* This should never appends! */

Until 74726 is fixed enough so that you can use nsXPIDLStrings, you should
probably use nsAutoStrings.

I can't find process_FCC defined anywhere - what am I missing? That's enough for
now...I'll look at more stuff later.

Comment 9

[Jean-Francois Ducarroz]

I have addressed all the points mentioned by bienvenu. Also I have removed a
unused string from the properties file (12518).

process_FCC is defined in nsIMsgSendReport.idl and used in nsIMsgSendReport.cpp
and nsMsgSend.cpp.

do you want me to post a updated patch?

Comment 10

[David :Bienvenu]

Does SetMessage2(PRInt32 process, nsString & message,

really need to take an nsString ref? It looks to me like it could just take a
wString

Comment 11

[Jean-Francois Ducarroz]

SetMessage2 is the nsString version of SetMessage which takes a wstring.

Comment 12

[David :Bienvenu]

Then why not call it SetMessageWithNsString? SetMessage2 is a meaningless name.
But what I was asking is why we need a version that takes an nsString.

Comment 13

[Jean-Francois Ducarroz]

You are rigth, I don't need it. The caller can just use the nsString::get()
function to pass a wstring to the SetMessage API. I am removing it and
correcting the code as well.

Comment 14

[Jean-Francois Ducarroz]

Attachment: proposed fix, v2

Comment 15

[David :Bienvenu]

why isn't +  nsIMsgProgress getProgress();

 readonly attribute nsIMsgProgress progress;

instead?

You don't need this anymore:

+%{C++
+#include "nsString.h"
+%}
+
+[ref] native nsStringRef(nsString);


other than that, sr=bienvenu

Comment 16

[Jean-Francois Ducarroz]

I fixed those last remaining issues and checked in the fix.

Comment 17

[grylchan]

Commercial builds
2001082008 - win nt 4.0
2001082108 - linux 2.2, mac 9.0.4

Following David's steps to reproduce as described in
bug 83682:
>To recreate this bug, rename your Local Folders directory to Local Folders2
>using the Windows File System Explorer, start up mozilla, go offline, compose a
>new msg, and do a send later. W/o this fix, it just silently fails. with this
>fix, you'll get the message I mentioned above.

The error message that now appears, if the Local Folder doesn't exist/isn't
correctly named, when doing a send later while offline is
    Send Later error:
       Unable to save your message in order
       to send it later. Please verify that your
       Mail/News account settings are correct and try again.

Marking as verified.