922549 - Bugzilla::Migrate.pm should provide hook in load function

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, enhancement)

Description

[rojanu]

Bugzilla::Migrate.pm should provide hook in load function to provide a way for extensions to provide custom import modules

Comment 1

[rojanu]

Attachment: Migrate_Modules_hook.patch

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 812571 [details] [diff] [review]
Migrate_Modules_hook.patch

Review of attachment 812571 [details] [diff] [review]:
-----------------------------------------------------------------

Hi aliustek,

So sorry for the delay in doing this review. This seems like a great idea, and the patch is well coded. There are a couple of things to fix on checkin, but r=gerv.

Gerv

::: Bugzilla/Hook.pm
@@ +1042,5 @@
> +This hashref contains the path and prefix for the modules to be used.
> +
> +=over
> +
> +=item C<path> - Path to where the modules are kept, on a typical extension this

Change comma to semicolon

::: extensions/Example/Extension.pm
@@ +602,5 @@
>  
> +sub migrate_modules {
> +    my ($self, $args) = @_;
> +    $args->{path} = bz_locations->{'extensionsdir'} . "/Example/lib/Migrate";
> +    $args->{prefix} = "Bugzilla::Extension::Example:Migrate";

Surely two colons here?

Comment 3

[Frédéric Buclin]

gerv, please commit.

Comment 4

[Gervase Markham [:gerv]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   a0c3ade..933fe72  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   933fe72..513b445  master -> master

Gerv