922625 - investigate more OutdatedDataErrors on balrog

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I thought we'd gotten rid of these with bug 851585, but it seems they're still occuring. Not a huge critical issue because of client side retries, but we should look into it sooner rather than later.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: don't let OutdatedDataErrors bubble up

I realized today that we're still getting these on Sentry because we're not catching these errors anywhere, so they bubble up as ISE 500. Since these are a type of failure that the user can correct, they should return 400s instead of 500s.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 816024 [details] [diff] [review]
don't let OutdatedDataErrors bubble up

lgtm

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6e7d13f7d54baf13c3e37c5ea672e2b755191b9e
bug 922625: investigate more OutdatedDataErrors on balrog. r=nthomas

Comment 4

[[e-mail] (:bhearsum)]

Rolled out in production in bug 926947. I marked the traceback as resolved in Sentry so it'll be easy to see if it continues to be an issue tomorrow. Anyone with access can look at https://errormill.mozilla.org/Releng/ to watch for it.

Comment 5

[[e-mail] (:bhearsum)]

Most nightlies for today have finished and we haven't seen any more instances of this. I'll keep an eye a bit longer, but this is strong confirmation of fixedness.