Closed Bug 922664 Opened 11 years ago Closed 11 years ago

Build omx-plugin in C++11 mode

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (v1) (obsolete) — Splinter Review
Spinoff from bug 920292.
Attachment #812656 - Flags: review?(chris.double)
Comment on attachment 812656 [details] [diff] [review]
Patch (v1)

Review of attachment 812656 [details] [diff] [review]:
-----------------------------------------------------------------

Please do one of the following:

1) Update media/omx-plugin/incude/ics/README_MOZILLA, update.sh and update.patch to include your changes so when updated with Android source your changes are included; or
2) Update README_MOZILLA explaining where the original source came from and that patches have been applied. Delete update.sh and update.patch. We'll lose the ability to easily provide updates here.

I'd opt for (2) since it's easier and we'll probably never need to update. If we do, we can diff.
Attachment #812656 - Flags: review?(chris.double) → review-
Attached patch Patch (v2)Splinter Review
Here's option #2.  :-)
Attachment #812656 - Attachment is obsolete: true
Attachment #812944 - Flags: review?(chris.double)
Attachment #812944 - Flags: review?(chris.double) → review+
https://hg.mozilla.org/mozilla-central/rev/bee118db5dfa
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: