Closed
Bug 922665
Opened 11 years ago
Closed 11 years ago
[AsyncShutdown] AsyncShutdown should check whether the crash reporter is enabled
Categories
(Toolkit :: Async Tooling, defect)
Toolkit
Async Tooling
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: Yoric, Assigned: Yoric)
Details
(Whiteboard: [Async:P1][Async Tooling])
Attachments
(1 file)
|
1.15 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
At the moment, if we do not check whether the crash reporter is enabled. If it is disabled, attempting to use it to annotate the crash throws an error.
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [Async:P1][Async Tooling]
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(dteller)
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #812678 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cc6d9eb30c0c Don't suppose a test for this would be possible/useful?
Flags: in-testsuite?
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
Since there is no way to deactivate the crash reporter from JS, I don't really see how we could test this. On the other hand, that patch really is trivial.
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc6d9eb30c0c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•