922697 - remove inline style and script

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Login, defect)

Description

[Pomax]

we have several places where we have inline script and inline styles (i.e. not loaded from .js or .css files) in our pages, and we should really try to refactor this so that this isn't the case anywhere anymore.

This ticket can act as a meta ticket while we do an inventory of locations that need fixing, blocked on individual refactors.

(bug from https://bugzilla.mozilla.org/show_bug.cgi?id=907781, itself the result of an request for CSP in our apps)

Comment 1

[Zakeria Hassan]

Hi,

Please assign this bug to me.

Thanks,
Zak
IRC:Vader

Comment 2

[Zakeria Hassan]

Running a search on the webmaker.org repo I found the inline styles used on the following pages:

> public/events/ext/js/jquery-ui-1.10.3.custom.js
> public/events/ext/js/jquery.css3finalize-v3.x.min.js
> public/events/js/events/map/markerclusterer.js
> views/details.html
> views/events/admin.html
> views/gallery.html
> views/make-templates/make-admin-search.html
> views/make-templates/make-flip.html
> views/make-templates/make-me.html
> views/make-templates/make-search.html
> views/make-templates/make-starter-make.html
> views/make-templates/make-teach.html
> views/style-guide.html
> views/template.html

Inline javascript on the following pages: 

> public/events/ext/js/jquery.form.js

> Im searching for uses of 'javascript:' for inline javascript and 'style=' for inline css styles.

Comment 3

[Chris DeCairos (:cade)]

I'm closing this bug as part of the planned deprecation of the Webmaker component on Bugzilla.

If this issue is still in need of fixing, you can file it on Github, where we track login related issues for Thimble.

https://github.com/mozilla/login.webmaker.org
https://github.com/mozilla/id.webmaker.org