922842 - Don't throw when IccHelper is undefined

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[James Lal [:lightsofapollo]]

This fails in various places where we use marionette and execute async script during startup:

Here is an example of the error:

JavaScriptError: (17) Error: Expected IccHelper to be enabled.

Remote Stack:

@app://system.gaiamobile.org/shared/js/operator_variant_helper.js, line 43

at Error.MarionetteError (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:463:19)

at /home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:492:21

at TcpSync.send (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:444:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:485:19)

at Object._executeScript (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:1421:19)

at Object.executeAsyncScript (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:1209:19)

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:658:14)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/marionette-js-client/lib/marionette/client.js:632:60)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/marionette-js-client/test/integration/wait-for-test.js:11:14)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runnable.js:213:32)

at Runner.runTest (/home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:351:10)

at /home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:397:12

at next (/home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:277:14)

at /home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:286:7

at next (/home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:234:23)

at Object._onImmediate (/home/travis/build/mozilla-b2g/marionette-js-client/node_modules/mocha/lib/runner.js:254:5)

at processImmediate [as _immediateCallback] (timers.js:330:15)

Comment 2

[James Lal [:lightsofapollo]]

This blocks some of the new test framework work we are doing... Cc'ing bsilverberg

Comment 3

[Aus Lacroix [:aus]]

Fixed.

Commit: https://github.com/mozilla-b2g/gaia/commit/9e2c09795be1360083546eeb0b5c7c7ead1ccf58

Comment 4

[James Lal [:lightsofapollo]]

This still throws: https://github.com/mozilla-b2g/gaia/commit/9e2c09795be1360083546eeb0b5c7c7ead1ccf58#diff-e78db030d3adca3be03f4ac8805431c9R58 ?

Comment 5

[Aus Lacroix [:aus]]

Hi James,

I had thought that bailing without throwing when IccHelper is undefined would be enough to solve the issue you were reporting. Guess that's not the case. Boo. :( The brute force option is to simply strip out the remaining exception that is unrelated to constructor arguments.

The other option requires me to peak at the logs to see what's going on. If I run 'make test-integration' locally, will I see the issue?

Comment 6

[James Lal [:lightsofapollo]]

Hmm... I am puzzled as to why it still is shown. I will get a test case for you (I didn't see the latest error myself)

Comment 7

[Aus Lacroix [:aus]]

This issue seems to be stale at this point since the code itself has changed and I think we're no longer blocked with the test framework implementation.

I'm going to go ahead and mark this WFM and we can open a new bug for future issues.