92292 - right clicking system tray icon in turbo mode brings up 2 "Exit" options

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Jacob Kjome]

Tested with build 2001072503 on Win2k (SP2)

There are two "Exit" items right click menu for the Mozilla turbo mode system
tray icon.  Didn't notice anythying like this before today's builds.

Expected:
one on "Exit" item

Actual:
two "Exit" items

jake

Comment 1

[Alfonso Martinez]

*** Bug 92493 has been marked as a duplicate of this bug. ***

Comment 2

[RC]

Attachment: screenshot of bug in Mozilla Build 2001072908 + Windows XP, sometimes both Exits are grayed out, sometimes one is grayed out, sometimes both are clickable -- and shouldn't it say "Exit Mozilla" instead of just "Exit"?

Comment 3

[RC]

Reporter is correct; no bug in 2001072403.

What happened between 2001072403 and 2001072503 that caused this?

Comment 4

[sairuh (rarely reading bugmail)]

->vishy for turbo bugs.

Comment 5

[Viswanath Ramachandran]

-> blaker

Comment 6

[Blake Ross]

Fix for this is in bug 89504.

Comment 7

[Grace Bush]

*** Bug 94543 has been marked as a duplicate of this bug. ***

Comment 8

[:deanis74]

Yes it is...

-        else {
-            ::AppendMenuW( mTrayIconMenu, MF_STRING, TURBO_QUIT, exitText.get() );
-        }

Marking dependent.  Since you've got a fix for this bug in that patch, would it
be possible to make a minor change and change line 758 from:

::EnableMenuItem( nsNativeAppSupportWin::mTrayIconMenu, 1, win ? MF_GRAYED :
MF_ENABLED );

  to

758 ::EnableMenuItem( nsNativeAppSupportWin::mTrayIconMenu, TURBO_QUIT,
MF_BYCOMMAND | (win ? MF_GRAYED : MF_ENABLED) );

The hard-coded assumption of the menu item at position 1 as the Exit item is
only going to produce another bug down the line.

Comment 9

[Blake Ross]

Fixed.

Comment 10

[Grace Bush]

Paul,

I can verify this is fixed on Mozilla build 2001081603- tested that yesterday

Comment 11

[Dennis]

Interesting, I have the same build 2001081603 and turbo mode is no longer 
functional.  The icon appears in the system tray then immediately disappears.  
Unfortunately, I can't right click on the turbo icon because it disapears too 
quickly. Anyhow, with this build turbo mode is dead here - same machine Windows 
NT 4 (SP6).  I will download todays build and report if this fixes my new 
problem.

Comment 12

[Jacob Kjome]

Dennis,

I experienced that for the last few days.  Today it seems fixed as of the 
7:00ish builds.

Jake

Comment 13

[Dennis]

Jake,
I have good news.  I have verified it's fixed with build 2001081703.

Comment 14

[Jacob Kjome]

Ug,

Slight problem, I think.  Remember this from Mike T's 7/29 comment?

"sometimes both Exits are grayed out, sometimes one is grayed out, sometimes 
both are clickable"

Well, with only the one exit option there (cool so far) I tried to close 
Mozilla down completely.  However, when I right clicked the system tray icon, I 
got a grayed out exist option which, obviously, would not exit Mozilla.

Looks like just a bit more work needs to be done.

Should this be re-opened or should I report a new bug?

jake

Comment 15

[David Illsley]

*** Bug 97446 has been marked as a duplicate of this bug. ***