922963 - update Unicode Bidi Algorithm implementation to v6.3

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Simon Montagu :smontagu]

(From http://www.unicode.org/versions/Unicode6.3.0/)

 Version 6.3 of the Unicode Standard is a special release focused on 
 delivering significantly improved bidirectional behavior.

 This new version updates the Unicode Bidirectional Algorithm to ensure that 
 pairs of parentheses and brackets have consistent layout and to provide a 
 mechanism for isolating runs of text.

ICU 52 (scheduled for release on 2013-10-09) includes support for the new features. We could either update the version of ICU code in layout/base/nsBidi.{h|cpp}, or start using intl/icu (which will also need updating) instead of nsBidi.

Comment 1

[Simon Montagu :smontagu]

Filed bug 924851 on using intl/icu instead of nsBidi

Comment 2

[Simon Montagu :smontagu]

At the same time we should implement the changes from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23260

Comment 3

[Behdad Esfahbod]

Simon, any idea when this will be done?

Comment 4

[Simon Montagu :smontagu]

Ehsan, do you know what the progress and prospects are with enabling ICU on Android and B2G? If that isn't happening in the near future, we won't be able to fix this via bug 924851 and we should consider backporting the ICU code for this to nsBidi.cpp.

Comment 5

[(no longer active)]

(In reply to Simon Montagu :smontagu from comment #4)
> Ehsan, do you know what the progress and prospects are with enabling ICU on
> Android and B2G? If that isn't happening in the near future, we won't be
> able to fix this via bug 924851 and we should consider backporting the ICU
> code for this to nsBidi.cpp.

I haven't looked back at the ICU stuff since the last time I touched it, sorry.  Bug 864843 seems to be awaiting some info from glandium...

Comment 6

[Ted Clancy [:tedders1]]

Hey Simon, are you working on this? Is it okay if I take it?

I've been working on support for LRI/RLI/FSI/PDI as part of a different issue. I hope I haven't duplicated any work.

Comment 7

[Simon Montagu :smontagu]

Ted, I won't have a chance to look at your patches before next week, but in principle I would rather fix this via bug 924851 or at least by backporting changes to ICU into nsBidi.cpp instead of forking our own support.

Comment 8

[Ted Clancy [:tedders1]]

Hey Simon,

I don't think I'm likely to backport changes from ICU, since that sounds like more work than I have time for right now. And unfortunately bug 924851 is blocked, as you know.

But if you don't want me writing my own code for the bidi algorithm, feel free to r- the patches. None of this stuff is blocking at the moment. I was hoping to have FSI/PDI support for some gaia stuff I'm working on, but it isn't essential.

Comment 9

[Aharon (Vladimir) Lanin]

Simon, how is bug 924851 actually blocked? It depends on bug 864843 and bug 866301, but neither of these seems to depend on any open bugs. Can this finally move forward?

Comment 10

[Ted Clancy [:tedders1]]

Stealing this.

Comment 11

[Ted Clancy [:tedders1]]

(In reply to Simon Montagu :smontagu from comment #7)
> Ted, I won't have a chance to look at your patches before next week, but in
> principle I would rather fix this via bug 924851 or at least by backporting
> changes to ICU into nsBidi.cpp instead of forking our own support.

Hi Simon. I'm not confident of Bug 924851 landing... ever.

I'm going to backport the changes to ICU into nsBidi.cpp.

Comment 12

[Ted Clancy [:tedders1]]

The code I'm porting over from ICU consists of two parts: support for Isolates, and support for Bracket Pairs.

Each of these parts is large, but they are largely independent of each other. I've split them into two separate bugs to make things more manageable.

Isolates is now Bug 1157726. Bracket Pairs is now Bug 1157727.

Comment 13

[Julien Wajsberg [:julienw]]

Hey Ted, I see the dependent bugs are fixed, so is this bug finished ?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:jfkthame, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 16

[Jonathan Kew [:jfkthame]]

The dependencies are all resolved, so AFAICS this is done and can be closed.
(If any aspect of the bidi algorithm seems broken, please file a new bug with details.)