Open Bug 922963 Opened 6 years ago Updated 3 years ago

update Unicode Bidi Algorithm implementation to v6.3

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

People

(Reporter: smontagu, Assigned: tedders1, NeedInfo)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-needed, rtl, Whiteboard: [systemsfe])

(From http://www.unicode.org/versions/Unicode6.3.0/)

 Version 6.3 of the Unicode Standard is a special release focused on 
 delivering significantly improved bidirectional behavior.

 This new version updates the Unicode Bidirectional Algorithm to ensure that 
 pairs of parentheses and brackets have consistent layout and to provide a 
 mechanism for isolating runs of text.

ICU 52 (scheduled for release on 2013-10-09) includes support for the new features. We could either update the version of ICU code in layout/base/nsBidi.{h|cpp}, or start using intl/icu (which will also need updating) instead of nsBidi.
Filed bug 924851 on using intl/icu instead of nsBidi
Depends on: 924851
At the same time we should implement the changes from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23260
Blocks: 717811
Simon, any idea when this will be done?
Ehsan, do you know what the progress and prospects are with enabling ICU on Android and B2G? If that isn't happening in the near future, we won't be able to fix this via bug 924851 and we should consider backporting the ICU code for this to nsBidi.cpp.
Flags: needinfo?(ehsan)
(In reply to Simon Montagu :smontagu from comment #4)
> Ehsan, do you know what the progress and prospects are with enabling ICU on
> Android and B2G? If that isn't happening in the near future, we won't be
> able to fix this via bug 924851 and we should consider backporting the ICU
> code for this to nsBidi.cpp.

I haven't looked back at the ICU stuff since the last time I touched it, sorry.  Bug 864843 seems to be awaiting some info from glandium...
Flags: needinfo?(ehsan)
Blocks: 1096421
Blocks: 1106835
Hey Simon, are you working on this? Is it okay if I take it?

I've been working on support for LRI/RLI/FSI/PDI as part of a different issue. I hope I haven't duplicated any work.
Flags: needinfo?(smontagu)
Depends on: 1151908
Depends on: 1151912
Depends on: 1151914
Depends on: 1151918
Depends on: 1151919
Depends on: 1151921
Depends on: 1151924
Blocks: 1152074
No longer blocks: 1152074
Blocks: 1152074
Ted, I won't have a chance to look at your patches before next week, but in principle I would rather fix this via bug 924851 or at least by backporting changes to ICU into nsBidi.cpp instead of forking our own support.
Flags: needinfo?(smontagu)
Hey Simon,

I don't think I'm likely to backport changes from ICU, since that sounds like more work than I have time for right now. And unfortunately bug 924851 is blocked, as you know.

But if you don't want me writing my own code for the bidi algorithm, feel free to r- the patches. None of this stuff is blocking at the moment. I was hoping to have FSI/PDI support for some gaia stuff I'm working on, but it isn't essential.
Flags: needinfo?(smontagu)
Simon, how is bug 924851 actually blocked? It depends on bug 864843 and bug 866301, but neither of these seems to depend on any open bugs. Can this finally move forward?
Blocks: 1154438
Stealing this.
Assignee: smontagu → tclancy
Flags: needinfo?(smontagu)
(In reply to Simon Montagu :smontagu from comment #7)
> Ted, I won't have a chance to look at your patches before next week, but in
> principle I would rather fix this via bug 924851 or at least by backporting
> changes to ICU into nsBidi.cpp instead of forking our own support.

Hi Simon. I'm not confident of Bug 924851 landing... ever.

I'm going to backport the changes to ICU into nsBidi.cpp.
Depends on: 1157726
Depends on: 1157727
The code I'm porting over from ICU consists of two parts: support for Isolates, and support for Bracket Pairs.

Each of these parts is large, but they are largely independent of each other. I've split them into two separate bugs to make things more manageable.

Isolates is now Bug 1157726. Bracket Pairs is now Bug 1157727.
Whiteboard: [systemsfe]
No longer blocks: 1154438
Depends on: 1160847
Blocks: 1185987
Depends on: 1281988
Hey Ted, I see the dependent bugs are fixed, so is this bug finished ?
Flags: needinfo?(ted.clancy)
You need to log in before you can comment on or make changes to this bug.