Closed Bug 922974 Opened 6 years ago Closed 6 years ago

Replace NO_INSTALL with NO_DIST_INSTALL

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

While fiddling with bug 921307, I hit an interesting case of us having $(DIST)/host/bin/nsinstall_real both installed from config/ and js/src/config/, and link_deps.py didn't like that. This, in turn looks like it was never intended to be installed anyways, and config/Makefile.in defines NO_INSTALL for that. NO_INSTALL used to be a variable to decide whether to install or not during make install. There is no real reason to install stuff in DIST if it's not meant to be installed with make install or packaged somehow, and i don't think nsinstall is used that way (but try may prove me wrong).

Anyways, interestingly, it seems NO_INSTALL slipped in recent parts of the tree (omx-plugin), with the intent of doing what NO_DIST_INSTALL does. Likewise for the testplugins. Even more interestingly, NO_DIST_INSTALL is *also* defined in the corresponding moz.build (except dom/plugins/test/testplugin/secondplugin).

Just kill it and replace with NO_DIST_INSTALL where it's not already there.
Blocks: 921307
Comment on attachment 812995 [details] [diff] [review]
Replace NO_INSTALL with NO_DIST_INSTALL

Review of attachment 812995 [details] [diff] [review]:
-----------------------------------------------------------------

Every Makefile in our tree is an ode to cargo culting.
Attachment #812995 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/c9d0dc574767
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Would it make sense to add NO_INSTALL to the blacklist in rules.mk?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.