Avoid copying data in GetSourceSurfaceForSurface

RESOLVED INACTIVE

Status

()

Core
Graphics
RESOLVED INACTIVE
5 years ago
4 days ago

People

(Reporter: mattwoodrow, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
The semantics of GetSourceSurfaceForSurface don't require us to copy the data, but we often end up calling CreateSourceSurfaceFromData which makes a copy.

On OSX at least, we hit this fairly often, so it seems worth trying to fix.

Very quick test to measure performance: https://tbpl.mozilla.org/?tree=Try&rev=ef18b616b25a

Looks like we could get a 2% (4mb) reduction in tp5 memory usage, and a 4% tscrollx win. Not huge, but probably worth having.

Bas, any thoughts on what you'd want the API to look like for this?
(Reporter)

Comment 1

5 years ago
Turning on azure content for OSX 10.6 regressed the tp5 memory usage by 2.8% (5.7mb), so fixing this would get most of that back.

I assume that azure content for 10.7/8 had a similar regression.

Comment 2

4 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 4 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.