Closed Bug 923026 Opened 6 years ago Closed 6 years ago
Make use of Preferences
.jsm in calendar code
I just came across http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/modules/Preferences.jsm which closely resembles our getPrefSafe / setPref functions. I think we should use this module and get rid of our pref handling functions. Since addons might be using our getPrefSafe/setPref, we should mark it as deprecated for one cycle and internally use Preferences.jsm.
Archaeopteryx, can I bug you for the review on this one? You have most experience in doing these kinds of changes. One issue that might arise is that our setPref/getPrefSafe just returned gracefully if something goes wrong and this version actually throws. I haven't tested this in detail, maybe you could give it a quick check?
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8383721 - Flags: review?(archaeopteryx)
Attachment #8383721 - Flags: review?(archaeopteryx) → review+
As discussed via IRC, we will keep the issues in mind for new code. Changing all existing code to rely on the pref-set default values is deemed to risky.
Pushed to comm-central changeset b14b32a5896e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.