Closed
Bug 923034
Opened 11 years ago
Closed 11 years ago
getCurrentState() never returns a falsy value
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 27
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
smacleod
:
review+
|
Details | Diff | Splinter Review |
SessionStore.getCurrentState() never returns a falsy value. We can remove this check in SessionSaver:
let state = SessionStore.getCurrentState(forceUpdateAllWindows);
if (!state) {
stopWatchCancel("COLLECT_DATA_MS", "COLLECT_DATA_LONGEST_OP_MS");
return;
}
Attachment #813043 -
Flags: review?(smacleod)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 813043 [details] [diff] [review]
Don't check getCurrentState's return value in SessionSaver
Review of attachment 813043 [details] [diff] [review]:
-----------------------------------------------------------------
Yup, definitely dead code, nice little cleanup :D
Attachment #813043 -
Flags: review?(smacleod) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in
before you can comment on or make changes to this bug.
Description
•