923059 - Two calls. Layout correction

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Call waiting layout, font sizes and spacing needs to be revised. Please follow this specs:
https://bug920526.bugzilla.mozilla.org/attachment.cgi?id=809867

Comment 1

[Victoria Gerchinhoren [:vicky]]

This comparison shows the incorrect things from the current implementation vs the desired result:
https://bug920526.bugzilla.mozilla.org/attachment.cgi?id=809870

Comment 2

[Victoria Gerchinhoren [:vicky]]

Attachment: Call waiting and conference call merging (screenshot VS ortiginal comparison)

Comment 3

[David Scravaglieri [:scravag]]

Blocking for missing information (names, icons...)

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Oh, seems I have some WIP in bug 894270..
Rik have you already started on this?

Comment 5

[Anthony Ricaud (:rik)]

Rex: I haven't. I'll probably wait till bug 894270 is landed before working on this. I'm not sure this bug will still be a koi+ once this landed.

Comment 6

[Anthony Ricaud (:rik)]

I'm removing koi+ because there is no loss of information anymore, bug 894270 added all of them. Also, I don't feel confident uplifting CSS patches to the call screen, it's a very sensitive piece. I'd prefer to use the normal trains for this.

Also, I'll need these assets to complete it:
- New red gradient for hang up button. 1px width, 40px height.
- New icon for "place new call", the phone with a +. 40px by 40px.

Could you also describe how we should change the dividers? It's hard for me to tell because there are 1px wide.

Comment 7

[Noemí Freire (:noemi)]

(In reply to Anthony Ricaud (:rik) from comment #6)
> 
> Also, I'll need these assets to complete it:
> - New red gradient for hang up button. 1px width, 40px height.
> - New icon for "place new call", the phone with a +. 40px by 40px.
> 

adding Peter for providing the needed icons here. Thanks!

Comment 8

[Noemí Freire (:noemi)]

sorry for the mistake, adding José Vittone to provide the needed input here: https://bugzilla.mozilla.org/show_bug.cgi?id=923059#c6

Comment 9

[José Vittone]

(In reply to Anthony Ricaud (:rik) from comment #6)
> Also, I'll need these assets to complete it:
> - New red gradient for hang up button. 1px width, 40px height.
> - New icon for "place new call", the phone with a +. 40px by 40px.

Hi Anthony, 

Here you have the assets for different screen densities: 
"red gradient" background:
https://www.dropbox.com/sh/5jqxx86jtqutknv/OaPWlI1vxV

"place new call" icon
https://www.dropbox.com/sh/heeb5f7nuq5z6t5/an4yO815fT

I'll be back with your last question related to dividers in a bit.

Comment 10

[José Vittone]

Please, forget about the "red gradient background", actually is well implemented. I've re-checked it with Victoria and the current gradient is OK. Actually the button on the design has an incorrect color.

Comment 11

[José Vittone]

Attachment: Dividers detail

Comment 12

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14109

Comment 13

[Anthony Ricaud (:rik)]

Attachment: Single call screenshot after patch

Comment 14

[Anthony Ricaud (:rik)]

Attachment: Two calls screenshot after patch

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8339139 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14109

r=me with nits addressed.

glad this is landing, well if the tree re-opens :)

Comment 16

[José Vittone]

Attachment: dialer-visual-fixes.png

Hi Anthony, 

I can't try the conference call, seems that the merge button doesn't work. The icon is displayed, I tap on it but nothing happens.

Great work! But I found some small issues (see the attachment): 

- When there's one active call:
-- The timestamp and "connecting" font weight should be light (300)
-- Icon next to the timestamp, looks blury for incoming and outcoming calls. Seems like is being resized.
-- In this scenario (just one call), the font size for contact's name should be 3.5rem
-- Long names are cut with ellipsis, but seems that there's some space wasted.
-- Wierd thing, the contact name font size changes after opening and closing the keypad. 

- When there're more than 1 active calls:
-- In this scenario (2 calls), the font size for contact's name should be 2.5rem, for both contacts.
-- Long names are cut with ellipsis, but seems that there's some space wasted.

Comment 17

[Anthony Ricaud (:rik)]

Comment on attachment 8339139 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14109

I've discussed this with José on IRC.

Putting this to review again:
- fixed the font-weight issue for the single call case (without breaking the two call case)
- call direction icons are 26px but were displayed at 24px

For font-size issues, I've opened bug 944340.
For ellipsis issues, I can't reproduce yet and I don't think it should block landing this. If it really reproduces, we'll fix it in another bug.

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 8339139 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14109

r=me with the tiny nit addressed.
apparently this also need rebasing.

Comment 19

[Anthony Ricaud (:rik)]

I had to rebase because of the removal of shadow on icons.

https://github.com/mozilla-b2g/gaia/commit/03e0658125cfea3cc4f5fbc97e170adbfef60010

Comment 20

[José Vittone]

I've created another bug related to ellipsis issue, https://bugzilla.mozilla.org/show_bug.cgi?id=944660
And another one for the alignment of the timestamp https://bugzilla.mozilla.org/show_bug.cgi?id=944669