923093 - No message while importing contacts from SIM when there are no contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Noemí Freire (:noemi)]

Attachment: v1.1_Import_From_SIM_Message.png

10/02 v1.2 build:
Gecko-f0e33a4
Gaia-7447624

Preconditions:
No contacts in the SIM card

STR
1. Go to Contacts->Settings->Import Contacts
2. Select SIM card source

EXPECTED
It should appear a message informing about this circumstance (See the message shown in v1.1)

ACTUAL
There is no message, no information about what happened with the import process

Comment 1

[Jose Manuel Cantera]

Attachment: 12662.html

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 813694 [details]
12662.html

Code wise looking perfect, could you add a unit test case to be sure we won't break this?

Thanks
F.

Comment 3

[Jose Manuel Cantera]

new test added and Travis is green. merged in master

https://github.com/mozilla-b2g/gaia/commit/77fa96d7db8e25ac359d8747db9d51ebbd940e71

Comment 4

[David Scravaglieri [:scravag]]

Blocked regression

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 77fa96d7db8e25ac359d8747db9d51ebbd940e71 to:
v1.2: 69881cd5aa09187f1ed555d880f8fa1d765601b1

Comment 6

[Matthew Vaughan]

I am seeing this bug reproduce on the 10/30/2013 1.2 build with comRIL. Should this bug be reopened or should I write a new bug?

Environmental Variables:
Device: Buri v1.2 comRIL
BuildID: 20131030004003
Gaia: a788ea1a3e04716938bd41a559c36a831cf1190b
Gecko: 4fbe1b01ed63
Version: 26.0a2
RIL Version: 01.01.00.019.264

Comment 7

[Jason Smith [:jsmith]]

Can you file a followup bug for the issue you hit?

Comment 8

[Matthew Vaughan]

I created bug 933381 (https://bugzilla.mozilla.org/show_bug.cgi?id=933381) for this issue.

Comment 9

[isabelrios]

Verified on v1.2 11/19 build:
Gecko-fab26c3
Gaia-9439907

It appears a message: No contacts on SIM detected to import, when trying to import during the FTE and from Contacts app