Closed Bug 923152 Opened 6 years ago Closed 6 years ago

[Contacts] Align with bug 914942 on how non-latin names are grouped in the import selection screen

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v1.2 affected)

RESOLVED FIXED
1.2 C3(Oct25)
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: jmcf, Assigned: mai)

References

Details

Attachments

(1 file, 1 obsolete file)

It is necessary to be aligned with the same solution adopted in bug 914942 for showing non-latin names under a concrete group instead of the default '#' group.
blocking-b2g: --- → leo?
Attached file proposal patch v1 (obsolete) —
Is this a localization issue?
Flags: needinfo?(mri)
No, it isn't. Sorry for delay.
Flags: needinfo?(mri)
Comment on attachment 813721 [details]
proposal patch v1

Please, could you review the code?
Regards.
Attachment #813721 - Flags: review?(jmcf)
Comment on attachment 813721 [details]
proposal patch v1

good work,

thanks
Attachment #813721 - Flags: review?(jmcf) → review+
https://github.com/mozilla-b2g/gaia/commit/3882d1b2c2249f6e4e8bde61247333ce900852f3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I should have tested it better before. Backed out as it is not working properly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file patch v1.1
Attachment #813721 - Attachment is obsolete: true
Attachment #820847 - Flags: review?(jmcf)
Attachment #820847 - Flags: review?(jmcf) → review+
now waiting to see Travis results
https://github.com/mozilla-b2g/gaia/commit/07dbb17d801bf955cf135b600d0aef19cd3d9619
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 C3(Oct25)
Jose, can you please state the end user impact that the patch has so we can atleast try to uplift this in 1.2 if needed. The criticality and the user impact is not clear to us to make this a blocking issue.
user impact is medium in non-latin languages, as all the contacts will appear under the '#' group. My recommendation would be to uplift as riks is low and we would not like to have less functionality than in v1.1
Mass-modify - removal of no longer relevant blocking flags.
blocking-b2g: leo? → ---
You need to log in before you can comment on or make changes to this bug.