Closed
Bug 923152
Opened 11 years ago
Closed 11 years ago
[Contacts] Align with bug 914942 on how non-latin names are grouped in the import selection screen
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
1.2 C3(Oct25)
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | affected |
People
(Reporter: jmcf, Assigned: mai)
References
Details
Attachments
(1 file, 1 obsolete file)
It is necessary to be aligned with the same solution adopted in bug 914942 for showing non-latin names under a concrete group instead of the default '#' group.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → leo?
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 813721 [details]
proposal patch v1
Please, could you review the code?
Regards.
Attachment #813721 -
Flags: review?(jmcf)
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 813721 [details]
proposal patch v1
good work,
thanks
Attachment #813721 -
Flags: review?(jmcf) → review+
Reporter | ||
Comment 6•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/3882d1b2c2249f6e4e8bde61247333ce900852f3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
Reporter | ||
Comment 7•11 years ago
|
||
I should have tested it better before. Backed out as it is not working properly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #813721 -
Attachment is obsolete: true
Attachment #820847 -
Flags: review?(jmcf)
Reporter | ||
Updated•11 years ago
|
Attachment #820847 -
Flags: review?(jmcf) → review+
Reporter | ||
Comment 9•11 years ago
|
||
now waiting to see Travis results
Reporter | ||
Comment 10•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/07dbb17d801bf955cf135b600d0aef19cd3d9619
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 1.2 C3(Oct25)
Comment 11•11 years ago
|
||
Jose, can you please state the end user impact that the patch has so we can atleast try to uplift this in 1.2 if needed. The criticality and the user impact is not clear to us to make this a blocking issue.
Reporter | ||
Comment 12•11 years ago
|
||
user impact is medium in non-latin languages, as all the contacts will appear under the '#' group. My recommendation would be to uplift as riks is low and we would not like to have less functionality than in v1.1
Comment 13•10 years ago
|
||
Mass-modify - removal of no longer relevant blocking flags.
Updated•10 years ago
|
blocking-b2g: leo? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•