Closed
Bug 923167
Opened 11 years ago
Closed 11 years ago
Make it possible to run java->C++ translator
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: smaug, Assigned: wchen)
Details
Attachments
(2 files)
1.14 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
1.35 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
I tried to follow the instructions from README.txt and that lead to stuff like javaparser/src/japa/parser/ast/stmt/IfStmt.java:2: error: unmappable character for encoding UTF8 * Copyright (C) 2007 J�lio Vilmar Gesser. and htmlparser/translator-src/nu/validator/htmlparser/generator/GenerateNamedCharacters.java:33: error: package nu.validator.htmlparser.annotation does not exist import nu.validator.htmlparser.annotation.CharacterName; ^ htmlparser/translator-src/nu/validator/htmlparser/generator/GenerateNamedCharacters.java:34: error: package nu.validator.htmlparser.annotation does not exist import nu.validator.htmlparser.annotation.NoLength;
Reporter | ||
Comment 1•11 years ago
|
||
Apparently import nu.validator.htmlparser.annotation.CharacterName; and import nu.validator.htmlparser.annotation.NoLength; can be just removed and if I remove the name J�lio Vilmar Gesser from sources I can compile it again. (I know, it is a hack)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → wchen
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #829673 -
Flags: review?(hsivonen)
Assignee | ||
Comment 3•11 years ago
|
||
I added an argument to compile the javaparser source files with ISO-8859-1 because that's the encoding of the the upstream project. And I removed the import statements for nu.validator.htmlparser.annotation.CharacterName and nu.validator.htmlparser.annotation.NoLength because those files are in the htmlparser project and the translator probably shouldn't have dependencies on the parser (nor is it necessary).
Attachment #829676 -
Flags: review?(hsivonen)
Updated•11 years ago
|
Attachment #829673 -
Flags: review?(hsivonen) → review+
Updated•11 years ago
|
Attachment #829676 -
Flags: review?(hsivonen) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff409a12b80e
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/ff409a12b80e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•