Closed Bug 923186 Opened 7 years ago Closed 7 years ago

Downloads button label gone

Categories

(Firefox :: Downloads Panel, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 27

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [Australis:M9][fixed-in-ux])

Attachments

(1 file)

I broke this in bug 845408, from the looks of it. Sadfaces all around.
Argh. So I think that my having issues with the label disappearing were because I hadn't added the label as an attribute. It seems to work fine now, and this is much nicer.
Attachment #813198 - Flags: review?(mconley)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 813198 [details] [diff] [review]
Download button should use regular XBL.

Review of attachment 813198 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, except for that one nit. Tested on OS X, and this does indeed fix the problem.

::: browser/base/content/browser.xul
@@ -911,5 @@
>                       oncommand="DownloadsIndicatorView.onCommand(event);"
>                       ondrop="DownloadsIndicatorView.onDrop(event);"
>                       ondragover="DownloadsIndicatorView.onDragOver(event);"
>                       ondragenter="DownloadsIndicatorView.onDragOver(event);"
>                       xmlns:xbl="http://www.mozilla.org/xbl"

Let's drop this xmlns:xbl namespace thingy now.
Attachment #813198 - Flags: review?(mconley) → review+
With nits, https://hg.mozilla.org/integration/fx-team/rev/669b06d30091
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/669b06d30091
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
https://hg.mozilla.org/projects/ux/rev/669b06d30091
Whiteboard: [Australis:M9][fixed-in-ux]
Verified as fixed on latest Firefox 27 beta 1 (buildID: 20131209204824) using Win 7 64-bit, Win 8.1 64-bit, Mac 10.8.5, Ubuntu 13.04 32-bit.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.