Build: 2001072503 Platform: Mac OS X Expected Results: Default plug-in should be supported What I got:Default plug-in isn't loaded by browser Steps to reproduce: 1) Go to a site that requires a plug-in that's not installed (For example, real.com) 2) Default plug-in isn't displayed.
Must be trivial to fix. --> Peter.
Another bug that would be fixed by bug 83754. I don't know if it's easier to fix that or covert the nullplugin to a be carbonized. Brian, do you know how much work it would be to carbonize: http://lxr.mozilla.org/seamonkey/source/modules/plugin/samples/default/mac
It looks like there is already TARGET_CARBON #ifdef code there. I don't know if there is a target in the project file or not. I don't imagine this would be terribly difficult, but I haven't done it before either. :)
Hm..there is tons of TARGET_CARBON code in there and it does seem to build something which kinda looks like the default plugin. Not sure if the project file needs to be modified, but there is only one target, "NullPluginPPC" and it doesn't appear the plugin gets loaded at run-time. What is needed to convert a project to build a library to run on CARBON?
I will carbonize thetself and get this fixed ASAP.
I added a new target to mozilla/modules/plugin/samples/default/mac/NullPlugin.mcp, which now uses MacPrefix.h as its prefix header, so I needed to add additional #includes to NullPlugin.cpp. Also links against CarbonLib and "MSL C.Carbon.Lib." Building this target by hand produces a working default plugin which causes the proper page to come up for downloading the Quicktime plugin when it has been put into the trash. Please review my trivial patch, and I'll get this checked into trunk as soon as possible.
Comment on attachment 50990 [details] [diff] [review] Patch to build NullPluginPPCCarbon target. r=peterl
Created attachment 50995 [details] [diff] [review] Build system changes to build Carbon target when appropriate.
sr=sfraser on the patches
Changes checked in on trunk.
check it in - PDT+
Changes checked into 094 branch.
Verified on the Sept 28th Mac OS X branch build. A better url to test it is to go to http://java.sun.com/. The Netscape Plug-ins dialog should appear with Get the Plug-in and Cancel buttons.
verified default plugins is on the mac os X branch build 0928 and it works as expected when a plugin is missing. adding keyword :vtrunk to verify on trunk l8r