Closed Bug 923248 Opened 6 years ago Closed 6 years ago
Fix typo in proxy/direct NTLM module telemetry accumulation
Can you find what is wrong with this code? mozilla::Telemetry::Accumulate( mozilla::Telemetry::NTLM_MODULE_USED, serviceFlags | nsIAuthModule::REQ_PROXY_AUTH ? NTLM_MODULE_SAMBA_AUTH_PROXY : NTLM_MODULE_SAMBA_AUTH_DIRECT); When we fix it, I suggest to change the probe names to prevent mixing current bad data with the new correct data. Taras?
Yes, we should change names. s/|/&/
Jason, this is simple. - exchanges the name of the probe from NTLM_MODULE_USED to NTLM_MODULE_USED_2 - fixes the | typo to &
Attachment #815003 - Flags: review?(jduell.mcbugs)
Comment on attachment 815003 [details] [diff] [review] v1 https://hg.mozilla.org/integration/mozilla-inbound/rev/0194c6474d7a
Attachment #815003 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.