Closed Bug 923248 Opened 10 years ago Closed 10 years ago

Fix typo in proxy/direct NTLM module telemetry accumulation

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file)

v1
4.89 KB, patch
jduell.mcbugs
: review+
mayhemer
: checkin+
Details | Diff | Splinter Review 
Can you find what is wrong with this code?

 mozilla::Telemetry::Accumulate(
		mozilla::Telemetry::NTLM_MODULE_USED,
		serviceFlags | nsIAuthModule::REQ_PROXY_AUTH
		? NTLM_MODULE_SAMBA_AUTH_PROXY
		: NTLM_MODULE_SAMBA_AUTH_DIRECT);


When we fix it, I suggest to change the probe names to prevent mixing current bad data with the new correct data.  Taras?
Yes, we should change names. s/|/&/
Attached patch v1 — — Splinter Review 
Jason, this is simple.

- exchanges the name of the probe from NTLM_MODULE_USED to NTLM_MODULE_USED_2
- fixes the | typo to &
Attachment #815003 - Flags: review?(jduell.mcbugs)
Attachment #815003 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/0194c6474d7a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.