Closed Bug 923345 Opened 7 years ago Closed 7 years ago

Intermittent TEST-UNEXPECTED-FAIL | test/browser_thumbnails_background_crash.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(Firefox :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
firefox-esr24 --- unaffected
b2g-v1.2 --- unaffected
b2g-v1.3 --- fixed

People

(Reporter: KWierso, Assigned: adw)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=28696560&tree=Mozilla-Inbound
using slave: talos-r3-fed64-058



18:00:14     INFO -  TEST-PASS | chrome://mochitests/content/browser/toolkit/components/thumbnails/test/browser_thumbnails_background_crash.js | We should have recovered and handled new capture requests: /tmp/tmp1q61AW/thumbnails/e82891364309427ebb2a6931429ff068.png
18:00:14     INFO -  TEST-PASS | chrome://mochitests/content/browser/toolkit/components/thumbnails/test/browser_thumbnails_background_crash.js | saw 2 crashes from this test
18:00:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/thumbnails/test/browser_thumbnails_background_crash.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
18:00:14     INFO -  INFO TEST-END | chrome://mochitests/content/browser/toolkit/components/thumbnails/test/browser_thumbnails_background_crash.js | finished in 37972ms
The logs for comment 4 and earlier are gone.  Comment 5 is not actually a timeout; it belongs in bug 917517.  In comment 6, the test times out right before calling finish(). :-/  So it's making progress but just taking a while.  There are only two sub-tests in this file so there's not much to split up, but it's probably a good idea.  After that we can request longer timeouts if necessary.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment on attachment 8345066 [details] [diff] [review]
split them up, move helpers to head.js, use framework in head.js, try not to change much else

Review of attachment 8345066 [details] [diff] [review]:
-----------------------------------------------------------------

personally I think a requestLongerTimeout() would have been better, but if you feel strongly about this approach, that's fine.
Attachment #8345066 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/b0ef6986d7a3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.