Build fails with "The MacroAssembler is not supported on this platform."

RESOLVED FIXED in mozilla27

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: stevensn, Assigned: stevensn)

Tracking

Trunk
mozilla27
PowerPC
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Building on ppc fails with the following errors

src/js/src/assembler/assembler/MacroAssembler.h:62:2: error: #error "The MacroAssembler is not supported on this platform."

when building js/src/vm/Runtime.cpp
This appears to have been with bug 921130
(Assignee)

Comment 1

4 years ago
Created attachment 813419 [details] [diff] [review]
923354.patch

Proposed fix - don't include  MacroAssembler.h on non ION platforms
(Assignee)

Updated

4 years ago
Attachment #813419 - Flags: review?(luke)

Comment 2

4 years ago
Comment on attachment 813419 [details] [diff] [review]
923354.patch

Great, sorry for breakage.  Can you indent the #if'd #include:

#if defined(JS_ION)
# include "assembler/assembler/MacroAssembler.h"
#endif
Attachment #813419 - Flags: review?(luke) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 813427 [details] [diff] [review]
923354.patch

Updated patch that indents the #include.
Attachment #813419 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/790dd24ecef2
Assignee: nobody → steve
Keywords: checkin-needed

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/790dd24ecef2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.