923363 - [Meta][User Story] Audio Peer Connection calls (WebRTC P2P)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ivan Tsay (:ITsay)]

This is the user story meta bug for webRTC.

Audio calls between Firefox OS phones or between Firefox OS & other Firefox products

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Removed items I argue do not block 1.3 (per comments in those bugs).  All of them have been moved from 1.3+ to 1.3? for re-classification (since I did not feel I should just remove the 1.3 nomination entirely, I set them to ? for re-consideration with a recommendation that they *not* block).

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

I'm having trouble getting the current builds to work reliably (on peak and helix).  I'm running patches 2 & 3 from bug 870660, which makes it possible to connect.  I was unable to connect peerconnections with regular builds; I tried switching to DEBUG builds of gecko and got intermittent connection of http://mozilla.github.com/webrtc-landing/data_test.html.  Note that this requests a fake:true audio channel (though it ignores it); for added fun fake:true channels were broken by some checkins for b2g right before IETF and the fix hasn't landed yet, so the audio would have been real.

gum_test.html works, with reasonable-sounding latency in the uncancelled feedback.

Attempts to connect at apprtc, talky, using pc_test and others did not seem to ever connect.  I was able to get http://mozilla.github.com/webrtc-landing/audio.html to connect I think, but I heard no audio.  Also, there seemed to be problems that required reboots to resolve.

Until I can get actual audio-only peerconnections to connect and play back, I can't test echo cancellation.  I wonder if I'm missing other patches, or if the current patches on 870660 need some more work.

Comment 3

[Jason Smith [:jsmith]]

Per discussion offline - targeted features don't block, so we don't need to continue blocking on this.

Comment 4

[Jean Gong :jgong]

Update whiteboard tag to follow format [ucid:{id}, {release}:p{1,2}, ft:{team-id}]

Comment 5

[Ivan Tsay (:ITsay)]

Hi Jason,

Is bug 945256 the feature blocker that prevent us from claiming the feature complete for this one? It seems to me the enabling of perf test option for this feature. Thank you!

Comment 6

[Ivan Tsay (:ITsay)]

(In reply to Randell Jesup [:jesup] on PTO until Dec 1 from comment #2)
> I'm having trouble getting the current builds to work reliably (on peak and
> helix).  I'm running patches 2 & 3 from bug 870660, which makes it possible
> to connect.  I was unable to connect peerconnections with regular builds; I
> tried switching to DEBUG builds of gecko and got intermittent connection of
> http://mozilla.github.com/webrtc-landing/data_test.html.  Note that this
> requests a fake:true audio channel (though it ignores it); for added fun
> fake:true channels were broken by some checkins for b2g right before IETF
> and the fix hasn't landed yet, so the audio would have been real.
> 
> gum_test.html works, with reasonable-sounding latency in the uncancelled
> feedback.
> 
> Attempts to connect at apprtc, talky, using pc_test and others did not seem
> to ever connect.  I was able to get
> http://mozilla.github.com/webrtc-landing/audio.html to connect I think, but
> I heard no audio.  Also, there seemed to be problems that required reboots
> to resolve.
> 
> Until I can get actual audio-only peerconnections to connect and play back,
> I can't test echo cancellation.  I wonder if I'm missing other patches, or
> if the current patches on 870660 need some more work.

Hi Randell,

Bug 870660 has been fully landed with 4 patches. I wonder if your question here is still the issue for you?

Comment 7

[Jason Smith [:jsmith]]

(In reply to Ivan Tsay (:ITsay) from comment #5)
> Hi Jason,
> 
> Is bug 945256 the feature blocker that prevent us from claiming the feature
> complete for this one? It seems to me the enabling of perf test option for
> this feature. Thank you!

Yes. We need to actually flip the pref back on in order to declare feature complete. Otherwise, you won't be able to use this feature on the phone by default.

Comment 8

[Ivan Tsay (:ITsay)]

Update to P2 in whiteboard since this is target feature.

Comment 9

[Jason Smith [:jsmith]]

This is officially a miss for 1.3. Branching has already started, so we're out of time to land this for 1.3. Moving to the 1.4 tracker.

Comment 10

[Ivan Tsay (:ITsay)]

Update whiteboard to v1.4

Comment 11

[Ivan Tsay (:ITsay)]

Update target milestone to sprint 1 of v1.4

Comment 12

[Jason Smith [:jsmith]]

per discussion in Thursday's call - we're going to move back to pushing this into 1.3. If we aren't able to reach an acceptable quality bar, then we'll move to 1.4.

Comment 13

[Jason Smith [:jsmith]]

I added some basic tests into MozTrap for this to test the browser matrix. This is by no means a full extent analysis of the P2P APIs, but this indicates we've got basic regression coverage in our full test runs.

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2514

Comment 14

[Ivan Tsay (:ITsay)]

Hi Maire/Jason,

I think we should "resolved fixed" this user story bug since all its dependency bugs are close including the Mochitest added for this feature? Any concerns?

Comment 15

[Jason Smith [:jsmith]]

Yeah, that's fine.

Comment 16

[Maire Reavy [:mreavy]]

Yeah, I agree