923369 - b2g may crash if b2g process restarts with bluetooth enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Eric Chou [:ericchou] [:echou]]

STR:
1. Leave Bluetooth enabled and restart b2g process.
2. Navigate to Settings->Bluetooth
3. b2g crash

It crashes because Gaia calls StartDiscovery() but Gecko cannot find valid sAdapterPath. I traced the code and found that GetDefaultAdapterPath() always returned false, which is because function RawDBusConnection::SendWithError() always returns false.

This is a regression of bug 919913. Patch incoming.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 813438 [details] [diff] [review]
patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error

Yeah, this looks much better. Sorry for making such an obvious mistake.

BTW: I'm not officially allowed to r+ this. In case someone cares, you might want to ask Kyle as well.

Comment 3

[Eric Chou [:ericchou] [:echou]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> Comment on attachment 813438 [details] [diff] [review]
> patch 1: v1: Return true when RawDBusConnection::SendWithError() executed
> without any error
> 
> Yeah, this looks much better. Sorry for making such an obvious mistake.
> 
> BTW: I'm not officially allowed to r+ this. In case someone cares, you might
> want to ask Kyle as well.

Sure. Thanks. :)

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 813438 [details] [diff] [review]
patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error

Hi Kyle,

Please review my patch. It's a simple one-line patch.

Thanks!

Comment 5

[Eric Chou [:ericchou] [:echou]]

Thank you both.

https://hg.mozilla.org/integration/b2g-inbound/rev/e3e8c2f68c34

Comment 6

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/e3e8c2f68c34

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

only impacting master
already fixed in v1.3 master
clear flag