b2g may crash if b2g process restarts with bluetooth enabled

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ericchou, Assigned: ericchou)

Tracking

({crash, regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b2g-crash])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
STR:
1. Leave Bluetooth enabled and restart b2g process.
2. Navigate to Settings->Bluetooth
3. b2g crash

It crashes because Gaia calls StartDiscovery() but Gecko cannot find valid sAdapterPath. I traced the code and found that GetDefaultAdapterPath() always returned false, which is because function RawDBusConnection::SendWithError() always returns false.

This is a regression of bug 919913. Patch incoming.
(Assignee)

Updated

4 years ago
Keywords: regression
(Assignee)

Comment 1

4 years ago
Created attachment 813438 [details] [diff] [review]
patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error
Assignee: nobody → echou
Attachment #813438 - Flags: review?(tzimmermann)

Updated

4 years ago
blocking-b2g: --- → 1.3?
Keywords: crash

Updated

4 years ago
Whiteboard: [b2g-crash]
Comment on attachment 813438 [details] [diff] [review]
patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error

Yeah, this looks much better. Sorry for making such an obvious mistake.

BTW: I'm not officially allowed to r+ this. In case someone cares, you might want to ask Kyle as well.
Attachment #813438 - Flags: review?(tzimmermann) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> Comment on attachment 813438 [details] [diff] [review]
> patch 1: v1: Return true when RawDBusConnection::SendWithError() executed
> without any error
> 
> Yeah, this looks much better. Sorry for making such an obvious mistake.
> 
> BTW: I'm not officially allowed to r+ this. In case someone cares, you might
> want to ask Kyle as well.

Sure. Thanks. :)
(Assignee)

Comment 4

4 years ago
Comment on attachment 813438 [details] [diff] [review]
patch 1: v1: Return true when RawDBusConnection::SendWithError() executed without any error

Hi Kyle,

Please review my patch. It's a simple one-line patch.

Thanks!
Attachment #813438 - Flags: review?(kyle)
Attachment #813438 - Flags: review?(kyle) → review+
(Assignee)

Comment 5

4 years ago
Thank you both.

https://hg.mozilla.org/integration/b2g-inbound/rev/e3e8c2f68c34

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/e3e8c2f68c34
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
only impacting master
already fixed in v1.3 master
clear flag
blocking-b2g: 1.3? → ---
You need to log in before you can comment on or make changes to this bug.