Various prompt service cleanup

RESOLVED FIXED in Firefox 27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Trunk
Firefox 27
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 813453 [details] [diff] [review]
Patch v1

While writing tests, I noticed that the prompt service isn't doing what I'd expect when the user hits "back" while its open. Namely, if the prompt has a checkbox on it, we act as if the checkbox was unchecked, even if it defaulted to checked.

We should ignore changes to the checkbox if the dialog is closed without pressing one of its buttons. I also noticed that in these cases, we're not actually even returning the checkbox value (so we always set the checkbox return value to false).

Along the way, I also split complex functions into smaller ones, and removed some unnecessary functions.
(Assignee)

Updated

5 years ago
Attachment #813453 - Flags: review?(mark.finkle)
Comment on attachment 813453 [details] [diff] [review]
Patch v1

Looks like some nice changes and good cleanup
Attachment #813453 - Attachment is patch: true
Attachment #813453 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/7b367ca427b6
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.