Closed
Bug 923406
Opened 11 years ago
Closed 11 years ago
Remove localizedFilenamePrefix from PlacesBackups.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: raymondlee, Assigned: raymondlee)
Details
Attachments
(1 file, 2 obsolete files)
|
10.42 KB,
patch
|
Details | Diff | Splinter Review |
A follow up. See 818584 comment 29.
|
Assignee | |
Comment 1•11 years ago
|
||
(In reply to Raymond Lee [:raymondlee] from comment #0)
> A follow up. See 818584 comment 29.
bug 818584 comment 29
|
||
Comment 2•11 years ago
|
||
just to clarify the request, it was there to support backwards compatibility with old backups, that scope has gone just by passing time so it's just useless code.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Just wait for patch for bug 818584 to land first.
|
|
||
Comment 4•11 years ago
|
||
This doesn't need to wait, I'll check if the patch applies yet and reviewland it in case.
No longer depends on: 818584
|
|
||
Updated•11 years ago
|
Assignee: nobody → raymond
Status: NEW → ASSIGNED
|
|
||
Updated•11 years ago
|
Attachment #813681 -
Flags: review?(mak77)
|
|
||
Comment 5•11 years ago
|
||
review in form of patch.
I cleaned up the test a little bit by using add_task. The changes in this patch allowed to fix a trivial bug in PlacesBackups where the backups number may exceed by 1 the specified maximum number of backups.
Attachment #813681 -
Attachment is obsolete: true
Attachment #813681 -
Flags: review?(mak77)
Attachment #8372988 -
Flags: review+
|
|
||
Comment 6•11 years ago
|
||
forgot to qref, this properly passes all of the tests
Attachment #8372988 -
Attachment is obsolete: true
|
|
||
Comment 7•11 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → mozilla30
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•