923406 - Remove localizedFilenamePrefix from PlacesBackups.js

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Raymond Lee [:raymondlee]]

A follow up.  See 818584 comment 29.

Comment 1

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #0)
> A follow up.  See 818584 comment 29.

bug 818584 comment 29

Comment 2

[Marco Bonardo [:mak]]

just to clarify the request, it was there to support backwards compatibility with old backups, that scope has gone just by passing time so it's just useless code.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v1

Just wait for patch for bug 818584 to land first.

Comment 4

[Marco Bonardo [:mak]]

This doesn't need to wait, I'll check if the patch applies yet and reviewland it in case.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1

review in form of patch.
I cleaned up the test a little bit by using add_task. The changes in this patch allowed to fix a trivial bug in PlacesBackups where the backups number may exceed by 1 the specified maximum number of backups.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.2

forgot to qref, this properly passes all of the tests

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14e9543664f4

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/14e9543664f4