Need to add the UniversalAutoDet to extensions makefiles.

RESOLVED FIXED in mozilla0.9.4

Status

()

Core
Internationalization
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Roy Yokoyama, Assigned: Roy Yokoyama)

Tracking

({topembed})

Trunk
mozilla0.9.4
x86
Windows 2000
topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: /r=nhotta; /sr=blizzard)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
Current \extensions\makefile doesn't make UniversalAutoDet
(Assignee)

Comment 1

17 years ago
Created attachment 43591 [details] [diff] [review]
adding universalchardet
(Assignee)

Comment 2

17 years ago
changing the milestone
Target Milestone: --- → mozilla0.9.4
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

17 years ago
QA Contact: andreasb → ylong
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

17 years ago
nhotta: can you /r= ?
cc'ing, bobj, nhotta, shanjian

Comment 4

17 years ago
r=nhotta
(Assignee)

Updated

17 years ago
Whiteboard: /r=nhotta; need /sr=
Has that code already been reviewed and super-reviewed?
(Assignee)

Comment 6

17 years ago
code has been reviewed by nhotta.
It needs a superview.  Can you super review, Chris?
sr=blizzard
There's a patch on bug 75924 to add "Makefile.in"s and make it so
--with-extensions=all builds universalchardet.  Should it also get built by
default on autoconf platforms (Unixes, OS/2, BeOS), even without
--with-extensions=all?  If so, that should be a 2-line patch to configure.in
after bug 75924 is checked in.
(Assignee)

Comment 9

17 years ago
checked-in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: /r=nhotta; need /sr= → /r=nhotta; /sr=blizzard; checked-in
Should this happen on other platforms?
(Assignee)

Comment 11

17 years ago
DAVID: yes. thank you.
Whiteboard: /r=nhotta; /sr=blizzard; checked-in → /r=nhotta; need /sr=

Comment 12

17 years ago
Roy: I can not check it on commercial trunk build, right? then could you please 
change QA contact to some other one?  Thanks!
(Assignee)

Comment 13

17 years ago
====changing to QA contact to ftang who can verify the makefile change.
QA Contact: ylong → ftang
(Assignee)

Comment 14

17 years ago
adding topembed keyword.
Keywords: topembed
Whiteboard: /r=nhotta; need /sr= → /r=nhotta; /sr=blizzard
(Assignee)

Comment 15

17 years ago
topembed: checked-into MOZILLA_0_9_2_BRANCH tree.
You need to log in before you can comment on or make changes to this bug.