Closed Bug 923417 Opened 7 years ago Closed 7 years ago

Enabling DataStore

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 4 obsolete files)

DataStore is ready to be enabled for b2g and non-release Desktop builds.
Attached patch patch (obsolete) — Splinter Review
Attachment #813489 - Flags: review?(ehsan)
Comment on attachment 813489 [details] [diff] [review]
patch

Review of attachment 813489 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +795,5 @@
>  // Enable promise
>  pref("dom.promise.enabled", false);
>  
>  // Enable dataStore
> +pref("dom.datastore.enabled", true);

Please hide this behind #ifndef RELEASE_BUILD.  We don't want to enable DataStore for our release builds until we have the security UI in place, and doing this here makes sure that we won't forget about this.

::: dom/tests/mochitest/general/test_interfaces.html
@@ +153,5 @@
>      "DataContainerEvent",
>      {name: "DataErrorEvent", b2g: true},
> +    "DataStore",
> +    "DataStoreChangeEvent",
> +    "DataStoreCursor",

This requires review from a DOM peer (jst?)

::: modules/libpref/src/init/all.js
@@ +4435,4 @@
>  pref("dom.datastore.enabled", false);
> +#else
> +pref("dom.datastore.enabled", true);
> +#endif

Why do we need to enable DataStore for non-b2g?
Attachment #813489 - Flags: review?(ehsan) → review-
Attached patch patch (obsolete) — Splinter Review
Attachment #813489 - Attachment is obsolete: true
Attachment #813533 - Flags: review?(jst)
Attachment #813533 - Flags: review?(ehsan)
Attachment #813533 - Flags: review?(ehsan) → review+
Attached patch dataStore_enabled.patch (obsolete) — Splinter Review
With the last change, the interfaces are enabled just on b2g so the mochitest needs this update too.
Attachment #813533 - Attachment is obsolete: true
Attachment #813533 - Flags: review?(jst)
Attachment #813699 - Flags: review?(jst)
Comment on attachment 813699 [details] [diff] [review]
dataStore_enabled.patch

>+++ b/dom/tests/mochitest/general/test_interfaces.html
>@@ -145,16 +145,19 @@ var interfaceNamesInGlobalScope =
>+    {name: "DataStore", b2g: true},
>+    {name: "DataStoreChangeEvent", b2g: true},
>+    {name: "DataStoreCursor", b2g: true},

{..., b2g: true, release: false}, otherwise it will break when uplifting to beta.
Still needs a sign-off from an official DOM peer.
Attached patch dataStore_enabled.patch (obsolete) — Splinter Review
Attachment #813699 - Attachment is obsolete: true
Attachment #813699 - Flags: review?(jst)
Attachment #813754 - Flags: review?(jst)
Attachment #813754 - Attachment is obsolete: true
Looks like this caused

243 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_all_synthetic_events.html | Unknown event found: DataStoreChangeEvent

on B2G ICS Emulator Opt mochitest-2.
https://hg.mozilla.org/mozilla-central/rev/9a98b8d47e3c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.