Enabling DataStore

RESOLVED FIXED in mozilla27

Status

()

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

({dev-doc-complete})

Trunk
mozilla27
x86_64
Linux
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

5 years ago
DataStore is ready to be enabled for b2g and non-release Desktop builds.
(Assignee)

Comment 1

5 years ago
Created attachment 813489 [details] [diff] [review]
patch
Attachment #813489 - Flags: review?(ehsan)
Keywords: dev-doc-needed

Comment 2

5 years ago
Comment on attachment 813489 [details] [diff] [review]
patch

Review of attachment 813489 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +795,5 @@
>  // Enable promise
>  pref("dom.promise.enabled", false);
>  
>  // Enable dataStore
> +pref("dom.datastore.enabled", true);

Please hide this behind #ifndef RELEASE_BUILD.  We don't want to enable DataStore for our release builds until we have the security UI in place, and doing this here makes sure that we won't forget about this.

::: dom/tests/mochitest/general/test_interfaces.html
@@ +153,5 @@
>      "DataContainerEvent",
>      {name: "DataErrorEvent", b2g: true},
> +    "DataStore",
> +    "DataStoreChangeEvent",
> +    "DataStoreCursor",

This requires review from a DOM peer (jst?)

::: modules/libpref/src/init/all.js
@@ +4435,4 @@
>  pref("dom.datastore.enabled", false);
> +#else
> +pref("dom.datastore.enabled", true);
> +#endif

Why do we need to enable DataStore for non-b2g?
Attachment #813489 - Flags: review?(ehsan) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 813533 [details] [diff] [review]
patch
Attachment #813489 - Attachment is obsolete: true
Attachment #813533 - Flags: review?(jst)
Attachment #813533 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #813533 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 813699 [details] [diff] [review]
dataStore_enabled.patch

With the last change, the interfaces are enabled just on b2g so the mochitest needs this update too.
Attachment #813533 - Attachment is obsolete: true
Attachment #813533 - Flags: review?(jst)
Attachment #813699 - Flags: review?(jst)
Comment on attachment 813699 [details] [diff] [review]
dataStore_enabled.patch

>+++ b/dom/tests/mochitest/general/test_interfaces.html
>@@ -145,16 +145,19 @@ var interfaceNamesInGlobalScope =
>+    {name: "DataStore", b2g: true},
>+    {name: "DataStoreChangeEvent", b2g: true},
>+    {name: "DataStoreCursor", b2g: true},

{..., b2g: true, release: false}, otherwise it will break when uplifting to beta.
Still needs a sign-off from an official DOM peer.
(Assignee)

Comment 6

5 years ago
Created attachment 813754 [details] [diff] [review]
dataStore_enabled.patch
Attachment #813699 - Attachment is obsolete: true
Attachment #813699 - Flags: review?(jst)
Attachment #813754 - Flags: review?(jst)
(Assignee)

Comment 8

5 years ago
Created attachment 813883 [details] [diff] [review]
dataStore_enabled.patch
Attachment #813754 - Attachment is obsolete: true
Looks like this caused

243 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_all_synthetic_events.html | Unknown event found: DataStoreChangeEvent

on B2G ICS Emulator Opt mochitest-2.
https://hg.mozilla.org/mozilla-central/rev/9a98b8d47e3c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Data Store API documented: https://developer.mozilla.org/en-US/docs/Web/API/Data_Store_API.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.