923417 - Enabling DataStore

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

DataStore is ready to be enabled for b2g and non-release Desktop builds.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[(no longer active)]

Comment on attachment 813489 [details] [diff] [review]
patch

Review of attachment 813489 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +795,5 @@
>  // Enable promise
>  pref("dom.promise.enabled", false);
>  
>  // Enable dataStore
> +pref("dom.datastore.enabled", true);

Please hide this behind #ifndef RELEASE_BUILD.  We don't want to enable DataStore for our release builds until we have the security UI in place, and doing this here makes sure that we won't forget about this.

::: dom/tests/mochitest/general/test_interfaces.html
@@ +153,5 @@
>      "DataContainerEvent",
>      {name: "DataErrorEvent", b2g: true},
> +    "DataStore",
> +    "DataStoreChangeEvent",
> +    "DataStoreCursor",

This requires review from a DOM peer (jst?)

::: modules/libpref/src/init/all.js
@@ +4435,4 @@
>  pref("dom.datastore.enabled", false);
> +#else
> +pref("dom.datastore.enabled", true);
> +#endif

Why do we need to enable DataStore for non-b2g?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 4

[Andrea Marchesini [:baku]]

Attachment: dataStore_enabled.patch

With the last change, the interfaces are enabled just on b2g so the mochitest needs this update too.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 813699 [details] [diff] [review]
dataStore_enabled.patch

>+++ b/dom/tests/mochitest/general/test_interfaces.html
>@@ -145,16 +145,19 @@ var interfaceNamesInGlobalScope =
>+    {name: "DataStore", b2g: true},
>+    {name: "DataStoreChangeEvent", b2g: true},
>+    {name: "DataStoreCursor", b2g: true},

{..., b2g: true, release: false}, otherwise it will break when uplifting to beta.
Still needs a sign-off from an official DOM peer.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: dataStore_enabled.patch

Comment 7

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4e60efc867f

Comment 8

[Andrea Marchesini [:baku]]

Attachment: dataStore_enabled.patch

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like this caused

243 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_all_synthetic_events.html | Unknown event found: DataStoreChangeEvent

on B2G ICS Emulator Opt mochitest-2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G mochitest-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb3bec184fec

https://tbpl.mozilla.org/php/getParsedLog.php?id=28770856&tree=Mozilla-Inbound

Comment 11

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=99b464b9e1df
The new patch is ready.

Comment 12

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a98b8d47e3c

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9a98b8d47e3c

Comment 14

[Chris Mills [:cmills]]

Data Store API documented: https://developer.mozilla.org/en-US/docs/Web/API/Data_Store_API.