Closed
Bug 923445
Opened 11 years ago
Closed 11 years ago
Home screen icons not aligned on first and other pages
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evyatar, Assigned: evyatar)
References
Details
Attachments
(1 file)
With e.me, the home screen icons should start from the second line, since the first line is "reserved" for e.me's search bar. Currently the second line of icons in the first page isn't align to the second line on the second page. STR: Simply start panning to the second page without lifting your finger. You'll see the 2 lines aren't perfectly aligned.
Assignee | ||
Comment 1•11 years ago
|
||
Cristian, what I did here was give a padding top which is identical to the total height of an icon (padding + image height + text margin + text height). Checked on Unagi and Peak.
Attachment #813518 -
Flags: review?(crdlc)
Comment 2•11 years ago
|
||
Comment on attachment 813518 [details]
Patch - redirect to github PR
Good catch
Attachment #813518 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
merge to master 44e718a698b5f3a24d8f6e189ae0c093286b5770 https://github.com/mozilla-b2g/gaia/commit/44e718a698b5f3a24d8f6e189ae0c093286b5770
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: --- → koi?
Assignee | ||
Comment 4•11 years ago
|
||
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•