923454 - e.me apps with 3 lines of text get their name cut off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

Long names are cut byt a few pixels at the bottom.

STR:
1. Open the "Social" collection
2. Swipe down to the bottom

Result:
"AirBNB Place to Stay" app's name is cut off at the bottom (the wod "Stay".

Expected:
The name should appear perfectly.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

2 main fixes here:
1) When calculating 3 lines of text we ignore the "line height", since there's spacing between each line. Added that.
2) The shadow of the text needed to be added to the final height of the text.

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 813534 [details]
Patch - redirect to github PR

10x

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

3 lines look good. But for some apps, a fourth line peaks.

Search for "maroon more night download"

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 813534 [details]
Patch - redirect to github PR

Fixed and looking good. Great Job!

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed in master
https://github.com/mozilla-b2g/gaia/commit/af6f9b86b68464cb3f14ca00788fcf844a0cfb48

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version