Created attachment 813537 [details] [diff] [review] no-warn.patch Since bug 923317, opt js builds have been spewing things like ../jsgcinlines.h:397:20: warning: unused variable ‘rt’ [-Wunused-variable] ../jsgcinlines.h: In instantiation of ‘T* js::gc::NewGCThing(js::ThreadSafeContext*, js::gc::AllocKind, size_t, js::gc::InitialHeap) [with T = JSScript; js::AllowGC allowGC = (js::AllowGC)1u; size_t = long unsigned int]’: ../jsgcinlines.h:478:89: required from here Here's a patch. We can't use DebugOnly sadly.
Attachment #813537 - Flags: review?(terrence)
Attachment #813537 - Flags: review?(terrence) → review?(wmccloskey)
Attachment #813537 - Flags: review?(wmccloskey) → review+
QA Contact: benjamin
Won't this patch break builds when JS_ASSERT is #defined but JS_GC_ZEAL is not? The rt variable is used in the JS_ASSERTs.
DEBUG implies JS_GC_ZEAL
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.