923543 - Figure out what to do with blanket Toolbar.png rule on Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/file/b46dbad96b50/browser/themes/linux/browser.css#l487

This is a little sad. I contained the problem right now by using a -moz-image-region that uses the fallback icon. AFAICT the Toolbar.png reference can just be removed, because it was only ever useful for a very small number of buttons (see http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/Toolbar.png ) and all of those are now covered by toolbarbuttons.inc.css, I believe.

Does that sound OK to people? (I didn't do this immediately because I didn't want to cause havoc in a bustage fix if there was something I was missing)

Comment 1

[:Gijs (he/him)]

Attachment: remove blanket toolbar.png rule,

The more I think about this, the more I think this is the right idea. We don't have this rule on our other platforms, and the only thing this could break is buttons that we don't explicitly set icons for in toolbarbuttons.inc but did rely on this behaviour, which could only be add-ons reusing our icons within the main browser window, which would be a bad idea anyway.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 815537 [details] [diff] [review]
remove blanket toolbar.png rule,

Can you remove -moz-box-orient: vertical; as well? Not sure what the point of min-width: 0; is.

Comment 3

[:Gijs (he/him)]

With comments addressed: https://hg.mozilla.org/projects/ux/rev/a99a67ddfb41

(I've left the min-width, but I don't understand it either. Perhaps we should just remove that, too?)

Comment 4

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/a99a67ddfb41